Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix text visible issue in dark mode #5758

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

amitamrutiya
Copy link
Contributor

Description
Make text visible by making blockquote to p tag

This PR fixes #5757

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

image

@amitamrutiya amitamrutiya changed the title Chore: fix text visible issue in dark mode fix text visible issue in dark mode Aug 1, 2024
@l5io
Copy link
Contributor

l5io commented Aug 1, 2024

🚀 Preview for commit 4358660 at: https://66ab3aade48fd29a77336d66--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 1, 2024

🚀 Preview for commit b1adff7 at: https://66abb8478362b3171d52e68e--layer5.netlify.app

Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @amitamrutiya!

@@ -58,8 +58,6 @@ import ClusterImg from "./multi-cluster-kubernetes-management-with-meshery.webp"
A recent study showed that developers using Kubernetes were able to deploy new code changes at least 27% faster than developers without any container orchestration
solution.
</p>

<blockquote> Developers using Kubernetes were able to deploy new code changes at least 27% faster than developers without any container orchestration solution. </blockquote>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why its been removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's repetitive, check the p tag above that it's already written and duplicating here!

@Ashparshp
Copy link
Contributor

@amitamrutiya Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@amitamrutiya
Copy link
Contributor Author

Sure 😊

@sudhanshutech sudhanshutech merged commit 5a35993 into layer5io:master Aug 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

text color issue in dark mode.
4 participants