Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React] Migration to React Version-18 #5732

Closed
wants to merge 9 commits into from
Closed

[React] Migration to React Version-18 #5732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8bc24cf
[React] Migration to React Version-18
Aviral0702 Jul 26, 2024
8ab7724
fix:workflow script
Aviral0702 Jul 26, 2024
bd430fc
Merge branch 'layer5io:master' into master
Aviral0702 Jul 29, 2024
9d58fc1
Merge remote-tracking branch 'upstream/master'
Aviral0702 Aug 2, 2024
8e69351
Merge branch 'layer5io:master' into master
Aviral0702 Aug 3, 2024
6f4899f
Merge branch 'layer5io:master' into master
Aviral0702 Aug 4, 2024
f099445
Merge branch 'layer5io:master' into master
Aviral0702 Aug 6, 2024
b71e4b7
Merge branch 'layer5io:master' into master
Aviral0702 Aug 19, 2024
16ebd53
Merge branch 'layer5io:master' into master
Aviral0702 Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-deploy-site.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

- name: Install and Build 🔧
run: |
npm install
npm install --legacy-peer-deps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason?

npm run build

- name: Deploy 🚀
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-and-preview-site.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- name: Install and Build 🔧
run: |
npm install
npm install --legacy-peer-deps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have included this because some packages do not support React 18. Therefore, during the installation process, it will skip those packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but is it safe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not permanent change we will revert this when all the packages which currently do not support React - 18 are replaced. It is just to bypass those dependencies. I can build the site successfully after these changes. Also major dependency is Meshery-embed-design package i think when it will be upgraded we can remove this.

npm run noIndex

- name: Zip Site
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lighthouseci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: 19
- run: npm install && npm install -g @lhci/[email protected]
- run: npm install --legacy-peer-deps && npm install -g @lhci/[email protected]
- run: CI=false npm run build
- run: lhci collect --config=.desktop-lighthouserc.js
- run: lhci assert --config=.desktop-lighthouserc.js
Expand Down
Loading
Loading