Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying meshery designs added to layer5 learning-path #5715

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Alero-Awani
Copy link

Description

Added Deploying Meshery Designs to layer5 Learning path

Notes for Reviewers
Got this error when I tried to view the page.

Error in function ChapterCard in ./src/components/Learn-Components/Chapter-Card/index.js:10
Cannot read properties of undefined (reading 'frontmatter')

./src/components/Learn-Components/Chapter-Card/index.js:10
Open in Editor
   8 |       <div className="chapter-desc">
   9 |         <h3>
> 10 |           {chapter.frontmatter.chapterTitle
     |                   ^
  11 |             ? chapter.frontmatter.chapterTitle
  12 |             : chapter.frontmatter.courseTitle}
  13 |         </h3>

Signed commits

  • Yes, I signed my commits.

@sudhanshutech
Copy link
Member

@captain-Akshay ?

@Ashparshp
Copy link
Contributor

@Alero-Awani, checks are facing and also, anything to update or share?

@sudhanshutech
Copy link
Member

@vishalvivekm is this something you are carrying forward?

Copy link
Contributor

@vladboisa vladboisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Looks good overall. Thank you for helping Open-Source community.
But i have 1 little attention, in your commit, we have so much PNG files.
And i think we should to compress all of them, for example This service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants