Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed category slider in integrations page #5270

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

prabhjeevnijjar
Copy link
Contributor

@prabhjeevnijjar prabhjeevnijjar commented Jan 5, 2024

Description

This PR fixes #5269

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jan 5, 2024

🚀 Preview for commit 2d68a6e at: https://659837064804832d8bfabe93--layer5.netlify.app

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prabhjeevnijjar thank you.

Is there anything that we can do about this? This happens in Safari (and maybe other browsers).

Screenshot 2024-01-05 at 11 54 56 AM

@leecalcote
Copy link
Member

@prabhjeevnijjar, we have another issue with respect to maintaining aspect ration of the icons. I wonder if you might have a look into this as well. Screenshot from Chrome.

Screenshot 2024-01-05 at 11 57 47 AM

@prabhjeevnijjar
Copy link
Contributor Author

@prabhjeevnijjar, we have another issue with respect to maintaining aspect ration of the icons. I wonder if you might have a look into this as well. Screenshot from Chrome.

Screenshot 2024-01-05 at 11 57 47 AM

Just checked, Logo is too wide hence the compression

  1. We can change the logo (less wide preferably)
  2. I can use some css to make height smaller
  • conditionally for this particular logo
  • across all logos

let me know which one i go with.

@prabhjeevnijjar
Copy link
Contributor Author

@prabhjeevnijjar thank you.

Is there anything that we can do about this? This happens in Safari (and maybe other browsers).

Screenshot 2024-01-05 at 11 54 56 AM

Its safari only problem 😆
Work fine with chrome, brave

@vishalvivekm
Copy link
Member

@prabhjeevnijjar
Today, we've our weekly Websites meeting at 6:30 PM IST : https://meet.layer5.io/websites.
Let's get feedback on your work in today's call. Please add this as an agenda item in the meeting minutes.

@leecalcote
Copy link
Member

@prabhjeevnijjar, while we won't be able to change this logo, we can use content-fit or something similar to control it's display. Let me know if you get stuck and can't quite figure this one out.

@leecalcote
Copy link
Member

We can merge your progress, if you open up a new issue to track the other item discussed in the comments.

@prabhjeevnijjar
Copy link
Contributor Author

Sure

@prabhjeevnijjar
Copy link
Contributor Author

We can merge your progress, if you open up a new issue to track the other item discussed in the comments.
@leecalcote
Created a new Issue: #5307

@prabhjeevnijjar
Copy link
Contributor Author

We can merge your progress, if you open up a new issue to track the other item discussed in the comments.

Created new issue for stretching of some logos: #5308

@vishalvivekm
Copy link
Member

Thank you @prabhjeevnijjar

@vishalvivekm vishalvivekm merged commit 652f01d into layer5io:master Feb 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Integration categories disapper on clearing search text
4 participants