Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commonForm.style.js] text color fix in dropdown #5246

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

prabhjeevnijjar
Copy link
Contributor

Description

This PR fixes #5242 #5232

Notes for Reviewers
`The behaviour of styling tag is not linear across browsers in different OS. This is also mentioned in the MDN docs. Behaviour of

Mac OS

  • Background color and text color is picked by default based on browser theme, This works perfectly

Windows

  • Shows white background all the time independent of the browser theme
  • But text color can be changed by CSS,
  • We were using -> props.theme.primaryColor [It changes the text color to white in dark theme, Which was the exact issue]
  • I changed it to -> props.theme.textColor [Now it stays in a shade of grey]`

Signed commits

  • Yes, I signed my commits.

Signed-off-by: prabhjeevnijjar <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 30, 2023

🚀 Preview for commit 8c1d978 at: https://658fb6c2541fd53898004ee5--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

Hey @prabhjeevnijjar,
Thanks for raising the PR, Please add this as your agenda in Doc to discuss it in the Website Meeting tomorrow at 6:30 PM IST.

Subscribe to community calendar for more details of meetings at Layer5.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently:

Screenshot 2024-01-14 at 1 07 44 PM

With this PR's change:

Screenshot 2024-01-14 at 1 07 48 PM

@leecalcote
Copy link
Member

@vishalvivekm @iArchitSharma @ritiksaxena124 please prioritize this fix.

@iArchitSharma
Copy link
Contributor

Fixed
image
image

@l5io
Copy link
Contributor

l5io commented Jan 14, 2024

🚀 Preview for commit f943adf at: https://65a45572e7ac41c3f4c32571--layer5.netlify.app

@leecalcote
Copy link
Member

Thank you, @prabhjeevnijjar and @iArchitSharma

@leecalcote leecalcote merged commit 9063704 into layer5io:master Jan 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"Select your role" dropdown not visible in dark mode
5 participants