Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[commonForm.style.js] fixed issue #5232 #5242 #5236

Closed
wants to merge 3 commits into from
Closed

[commonForm.style.js] fixed issue #5232 #5242 #5236

wants to merge 3 commits into from

Conversation

kishore2k
Copy link

@kishore2k kishore2k commented Dec 27, 2023 •
edited
Loading

Description
Signed-off-by: Kishore [email protected]

This PR fixes #5232 #5242

Notes for Reviewers
Fixed the options not visible in roles dropdown list on meshmap page under "Join the Beta Form"

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Dec 27, 2023

🚀 Preview for commit cf6cf78 at: https://658be0bf3098fa3873d5c025--layer5.netlify.app

@kishore2k kishore2k changed the title [commonForm.style.js] fixed issue #5232 [commonForm.style.js] fixed issue #5232 #5242 Dec 28, 2023
leecalcote
leecalcote requested changes Dec 28, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kishore2k. We shouldn't need to mandate a white background and black text. They should invert based on current color mode.

Screenshot 2023-12-28 at 8 30 55 AM

@kishore2k kishore2k marked this pull request as draft December 28, 2023 14:55
@l5io
Copy link
Contributor

l5io commented Dec 28, 2023

🚀 Preview for commit 209bfef at: https://658d8f779ab4710fb93be1b3--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

Hey @kishore2k,
Thanks for raising the PR, Please add this as your agenda in Doc to discuss it in the Website Meeting tomorrow at 6:30 PM IST.

Subscribe to community calendar for more details of meetings at Layer5.

@l5io
Copy link
Contributor

l5io commented Jan 4, 2024

🚀 Preview for commit d30b909 at: https://659633e4a034602f4f790f74--layer5.netlify.app

@kishore2k kishore2k closed this by deleting the head repository Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Options not visible in roles dropdown list on meshmap page
4 participants
@kishore2k @l5io @saurabh100ni @leecalcote