Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link fixed #5122

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Broken link fixed #5122

merged 1 commit into from
Nov 14, 2023

Conversation

iArchitSharma
Copy link
Contributor

@iArchitSharma iArchitSharma commented Nov 14, 2023

Description
/projects/service-mesh-performance is now redirected to /projects/cloud-native-performance and thus 404 error is resolved

Fixes:
image

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Archit Sharma <[email protected]>
@l5io
Copy link
Contributor

l5io commented Nov 14, 2023

🚀 Preview for commit c63db02 at: https://65531c1c36adbd25cb7dc37c--layer5.netlify.app

@sandramsc
Copy link
Member

@iArchitSharma Please indicate (with issue number) which issue this PR attempts to resolve, this aids reviewers give feedback more efficiently.

@iArchitSharma
Copy link
Contributor Author

@iArchitSharma Please indicate (with issue number) which issue this PR attempts to resolve, this aids reviewers give feedback more efficiently.

There is no issue created for this, reviewers are already aware of it!

@leecalcote leecalcote merged commit 4517b72 into layer5io:master Nov 14, 2023
7 checks passed
@leecalcote
Copy link
Member

I saw these comments after merging...

@sandramsc
Copy link
Member

sandramsc commented Nov 14, 2023

For any contributor coming across this issue or if someone were to refer back to it in future, there could've been more clarity in the PR description (or a created issue)..indicating first that this was an issue. Perhaps a minor one, hence the PR approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/site-config kind/bug Something isn't working
Development

Successfully merging this pull request may close these issues.

4 participants