Added maintainers column to backend projects #5088

ankushbhardwaj408 · 2023-10-30T16:53:35Z

Description

This PR fixes #5057

Notes for Reviewers

Signed commits

Yes, I signed my commits.

Signed-off-by: Ankush Bhardwaj <[email protected]>

l5io · 2023-10-30T17:12:24Z

🚀 Preview for commit 1faf54e at: https://653fe3a92f843312ba33995d--layer5.netlify.app

…shbhardwaj408-layer5io#5057

l5io · 2023-11-04T09:56:43Z

🚀 Preview for commit 9f9b656 at: https://654614e7a334a965c8c3c612--layer5.netlify.app

abhijeetgauravm · 2023-11-05T14:54:45Z

Hey @ankushbhardwaj408 Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

ritiksaxena124

Merge Conflicts

Signed-off-by: Ankush Bhardwaj <[email protected]>

ankushbhardwaj408 · 2023-11-05T17:49:06Z

@ritiksaxena124 Done.

l5io · 2023-11-05T18:04:07Z

🚀 Preview for commit 96045fa at: https://6547d89816594777825ea358--layer5.netlify.app

iArchitSharma

LGTM!

l5io · 2023-11-06T17:30:34Z

🚀 Preview for commit b5d621e at: https://6549222f3350cd1d91c122d7--layer5.netlify.app

Mohith234

Yay 🎈, LGTM @ankushbhardwaj408

leecalcote

Will you please undo any changes not directly related to the issue?

ankushbhardwaj408 · 2023-11-07T03:53:02Z

@leecalcote Thank you for your input. I have carefully reviewed the changes, and there are no changes that are not related to the problem, if there are still any please let me know

iArchitSharma · 2023-11-07T08:10:08Z

@leecalcote Thank you for your input. I have carefully reviewed the changes, and there are no changes that are not related to the problem, if there are still any please let me know

@ankushbhardwaj408 I think Lee is referring to the code formatting here. Can you keep the formatting as it was?

Signed-off-by: Ankush Bhardwaj <[email protected]>

…ankushbhardwaj408/layer5 into ankushbhardwaj408-layer5io#5057

Signed-off-by: Ankush Bhardwaj <[email protected]>

ankushbhardwaj408 · 2023-11-07T08:58:24Z

@iArchitSharma Done.

l5io · 2023-11-07T09:14:33Z

🚀 Preview for commit 7905cd7 at: https://6549ffb261fe677640aa10a0--layer5.netlify.app

l5io · 2023-11-13T16:38:48Z

🚀 Preview for commit 3425bd8 at: https://6552508f9684d803e6ee8fed--layer5.netlify.app

iArchitSharma · 2023-11-14T05:22:22Z

LGTM!

leecalcote · 2023-11-14T20:17:19Z

src/sections/Community/Handbook/repo-data.js

@@ -168,24 +173,28 @@ export const repo_data = [
        project: "Cloud Native Labs",


Please change this to Cloud Native Learning Paths (https://layer5.io/learn/learning-paths)

leecalcote · 2023-11-14T20:18:12Z

src/sections/Community/Handbook/repo-data.js

-        repository:
-          "https://github.com/meshery/play",
-      }
+        maintainers_name: ["Nikhil Ladha"],


Please leave maintainer vacant.

leecalcote · 2023-11-14T20:18:46Z

src/sections/Community/Handbook/repo-data.js

@@ -228,37 +239,56 @@ export const repo_data = [
        project: "Meshery",
        image: meshery,
        language: "Golang, gRPC",
-        description: "the cloud native management plane to provide governance and backend system integration. Golang, gRPC, NATS, CloudEvents",
+        maintainers_name: ["Nikhil Ladha", "Aaditya Narayan Subedy"],


Please swap with @MUzairS15 and @nebula-aac

leecalcote · 2023-11-14T20:19:11Z

src/sections/Community/Handbook/repo-data.js

        repository: "https://github.com/meshery/meshery-operator",
      },
      {
        project: "MeshSync",
        image: MeshSync,
        language: "Golang and NATS",
-        description: "MeshSync is a multi-mesh resource discovery application which is also a custom kubernetes controller.",
+        maintainers_name: ["Vacant"],


Please add @theBeginner86

leecalcote · 2023-11-14T20:19:23Z

src/sections/Community/Handbook/repo-data.js

@@ -284,14 +314,20 @@ export const repo_data = [
        project: "Image Hub",
        image: imagehub,
        language: "Vuejs",
-        description: "A sample application written to run on Istio or Consul for exploring WebAssembly modules used as Envoy filters.",
+        maintainers_name: ["Lee Calcote"],


Please leave vacant.

leecalcote · 2023-11-14T20:19:47Z

src/sections/Community/Handbook/repo-data.js

-        description: "meshery-perf is a Meshery component used to run performance tests",
-        repository: "https://github.com/meshery/meshery-perf"
-      }
+        maintainers_name: ["Vacant"],


@gyohuangxin? - - he'll have to confirm...

I'll change it after @gyohuangxin confirms.

leecalcote · 2023-11-14T20:20:03Z

src/sections/Community/Handbook/repo-data.js

@@ -359,6 +417,12 @@ export const repo_data = [
        project: "Cloud Native Patterns",
        image: patterns,
        language: "Yaml",
+        maintainers_name: ["Lee Calcote", "Nic Jackson", "Nikhil Ladha"],


Remove Nikhil.

leecalcote · 2023-11-14T20:20:29Z

src/sections/Community/Handbook/repo-data.js

        description: "Meshery adapter for management of Network Service Mesh.",
        repository: "https://github.com/layer5io/meshery-nsm",
      },
      {
        project: "Meshery Adapter for Octarine",
        image: meshery,
        language: "Golang, gRPC",
+        maintainers_name: ["Lee Calcote"],


Please move this Adapter altogether. It has been archived.

leecalcote · 2023-11-14T20:20:53Z

src/sections/Community/Handbook/repo-data.js

        description: "Meshery adapter for management of AWS App Mesh",
        repository: "https://github.com/layer5io/meshery-app-mesh",
      },
      {
        project: "Meshery Adapter for Tanzu Service Mesh",
        image: meshery,
        language: "Golang, gRPC",
-        description: "Meshery adapter for management of VMware Tanzu Service Mesh",
+        maintainers_name: ["Xin Huang"],


This should be @hexxdump

leecalcote · 2023-11-14T20:21:10Z

src/sections/Community/Handbook/repo-data.js

        description: "Meshery adapter for management of NGINX Service Mesh",
        repository: "https://github.com/layer5io/meshery-nginx-sm",
      },
      {
        project: "Meshery Adapter for Cilium Service Mesh",
        image: ciliumLogo,
        language: "Golang, gRPC",
+        maintainers_name: ["Xin Huang"],


Switch to @MUzairS15

leecalcote · 2023-11-14T20:21:46Z

src/sections/Community/Handbook/repo-data.js

        repository: "https://github.com/layer5io/meshery-adapter-library",
      },
      {
        project: "Meshery Adapter Template",
        image: meshery,
        language: "Golang, gRPC",
-        description: "A GitHub repo used as a template for new Meshery Adapters.",
+        maintainers_name: ["Antonette Caldwell"],


Please leave vacant.

leecalcote · 2023-11-14T20:22:20Z

src/sections/Community/Handbook/repo-data.js

@@ -195,29 +204,31 @@ export const repo_data = [
        project: "Linkerd Service Mesh Workshop",
        image: linkerdLogo,
        language: "Meshery",
+        maintainers_name: ["Hussaina Begum"],


Please leave vacant.

leecalcote · 2023-11-14T20:22:54Z

src/sections/Community/Handbook/repo-data.js

@@ -304,6 +340,18 @@ export const repo_data = [
        project: "Cloud Native Performance",
        image: smp,
        language: "Protobuf",
+        maintainers_name: [


Please add @asubedy

Signed-off-by: Ankush Bhardwaj <[email protected]>

l5io · 2023-11-15T04:29:11Z

🚀 Preview for commit 0fe13da at: https://6554487fd4c7e0572ef28aef--layer5.netlify.app

Signed-off-by: Ankush Bhardwaj <[email protected]>

ankushbhardwaj408 · 2023-11-15T04:47:07Z

@leecalcote I've created PRs to add maintainers.md layer5io/sistent#339 meshery/meshery#9365

l5io · 2023-11-15T04:52:33Z

🚀 Preview for commit 767073c at: https://65544dfc4bbe7259d05f3357--layer5.netlify.app

l5io · 2023-11-16T04:13:27Z

🚀 Preview for commit 3e2eeba at: https://6555965f0030203272b79370--layer5.netlify.app

src/sections/Community/Handbook/repo-data.js

leecalcote · 2023-11-16T04:21:27Z

src/sections/Community/Handbook/repo-data.js

        description: "Meshery adapter for management of Consul",
        repository: "https://github.com/layer5io/meshery-consul",
      },
      {
        project: "Meshery Adapter for CPX",
        image: meshery,
        language: "Golang, gRPC",
+        maintainers_name: ["Lee Calcote"],


Suggested change

maintainers_name: ["Lee Calcote"],

maintainers_name: ["Vacant"],

src/sections/Community/Handbook/repo-data.js

Signed-off-by: Lee Calcote <[email protected]>

leecalcote · 2023-11-16T04:23:07Z

src/sections/Community/Handbook/repo-data.js

@@ -41,26 +41,29 @@ export const repo_data = [
        image: meshery,
        site: "https://meshery.io",
        language: "Jekyll",
-        maintainers_name: ["Vacant"],
-        link: ["#"],
+        maintainers_name: ["Nikhil Ladha"],


Change to Vivek Vishal, please.

@leecalcote Done.

Signed-off-by: Ankush Bhardwaj <[email protected]>

l5io · 2023-11-16T05:10:12Z

🚀 Preview for commit 7a1c9b0 at: https://6555a3a243d1113b3204625a--layer5.netlify.app

leecalcote · 2023-11-17T21:07:16Z

Thank you, @ankushbhardwaj408 👏

ankushbhardwaj408 · 2023-11-18T04:03:24Z

Thanks to you @leecalcote for your patience and all the suggestions. Happy to contribute!🫡

Added maintainers column to backend projects

1faf54e

Signed-off-by: Ankush Bhardwaj <[email protected]>

github-actions bot added the area/handbook label Oct 30, 2023

abhijeetgauravm requested review from leecalcote and vishalvivekm October 30, 2023 18:13

Merge branch 'master' of https://github.com/layer5io/layer5 into anku…

9f9b656

…shbhardwaj408-layer5io#5057

ritiksaxena124 reviewed Nov 5, 2023

View reviewed changes

resolved merge conflicts

96045fa

Signed-off-by: Ankush Bhardwaj <[email protected]>

iArchitSharma approved these changes Nov 6, 2023

View reviewed changes

Merge branch 'master' into ankushbhardwaj408-layer5io#5057

b5d621e

Mohith234 approved these changes Nov 6, 2023

View reviewed changes

leecalcote requested changes Nov 6, 2023

View reviewed changes

ankushbhardwaj408 added 4 commits November 7, 2023 14:05

undo unnecessary changes

100470d

Signed-off-by: Ankush Bhardwaj <[email protected]>

Merge branch 'ankushbhardwaj408-layer5io#5057' of https://github.com/…

c16cdf4

…ankushbhardwaj408/layer5 into ankushbhardwaj408-layer5io#5057

undo unnecessary changes

814cadd

Signed-off-by: Ankush Bhardwaj <[email protected]>

undo unnecessary changes

7905cd7

Signed-off-by: Ankush Bhardwaj <[email protected]>

Merge branch 'master' into ankushbhardwaj408-layer5io#5057

3425bd8

Merge branch 'master' into ankushbhardwaj408-layer5io#5057

0d4f776

ankushbhardwaj408 requested a review from leecalcote November 14, 2023 14:04

leecalcote reviewed Nov 14, 2023

View reviewed changes

leecalcote requested changes Nov 14, 2023

View reviewed changes

ankushbhardwaj408 added 2 commits November 15, 2023 09:23

updated maintainers

24308f2

Signed-off-by: Ankush Bhardwaj <[email protected]>

updated maintainers

0fe13da

Signed-off-by: Ankush Bhardwaj <[email protected]>

updated maintainers

767073c

Signed-off-by: Ankush Bhardwaj <[email protected]>

Merge branch 'master' into ankushbhardwaj408-layer5io#5057

3e2eeba

leecalcote reviewed Nov 16, 2023

View reviewed changes

src/sections/Community/Handbook/repo-data.js Outdated Show resolved Hide resolved

leecalcote reviewed Nov 16, 2023

View reviewed changes

src/sections/Community/Handbook/repo-data.js Outdated Show resolved Hide resolved

leecalcote reviewed Nov 16, 2023

View reviewed changes

src/sections/Community/Handbook/repo-data.js Outdated Show resolved Hide resolved

leecalcote reviewed Nov 16, 2023

View reviewed changes

src/sections/Community/Handbook/repo-data.js Outdated Show resolved Hide resolved

leecalcote reviewed Nov 16, 2023

View reviewed changes

src/sections/Community/Handbook/repo-data.js Outdated Show resolved Hide resolved

leecalcote reviewed Nov 16, 2023

View reviewed changes

src/sections/Community/Handbook/repo-data.js Outdated Show resolved Hide resolved

Apply suggestions from code review

2a9c867

Signed-off-by: Lee Calcote <[email protected]>

leecalcote reviewed Nov 16, 2023

View reviewed changes

Applied changes from suggestion

7a1c9b0

Signed-off-by: Ankush Bhardwaj <[email protected]>

leecalcote merged commit fe2464f into layer5io:master Nov 17, 2023
4 checks passed

ankushbhardwaj408 deleted the ankushbhardwaj408-#5057 branch November 20, 2023 04:43

		@@ -168,24 +173,28 @@ export const repo_data = [
		project: "Cloud Native Labs",

	maintainers_name: ["Lee Calcote"],
	maintainers_name: ["Vacant"],

Added maintainers column to backend projects #5088

Added maintainers column to backend projects #5088

Conversation

ankushbhardwaj408 commented Oct 30, 2023

l5io commented Oct 30, 2023

l5io commented Nov 4, 2023

abhijeetgauravm commented Nov 5, 2023

ritiksaxena124 left a comment

Choose a reason for hiding this comment

ankushbhardwaj408 commented Nov 5, 2023

l5io commented Nov 5, 2023

iArchitSharma left a comment

Choose a reason for hiding this comment

l5io commented Nov 6, 2023

Mohith234 left a comment

Choose a reason for hiding this comment

leecalcote left a comment

Choose a reason for hiding this comment

ankushbhardwaj408 commented Nov 7, 2023 • edited Loading

iArchitSharma commented Nov 7, 2023

ankushbhardwaj408 commented Nov 7, 2023

l5io commented Nov 7, 2023

l5io commented Nov 13, 2023

iArchitSharma commented Nov 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leecalcote Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l5io commented Nov 15, 2023

ankushbhardwaj408 commented Nov 15, 2023

l5io commented Nov 15, 2023

l5io commented Nov 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l5io commented Nov 16, 2023

leecalcote commented Nov 17, 2023

ankushbhardwaj408 commented Nov 18, 2023

ankushbhardwaj408 commented Nov 7, 2023 •

edited

Loading

leecalcote Nov 14, 2023 •

edited

Loading