Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Screenshots] Camel K under 'How it Works See It in Action' section #5031

Merged
merged 2 commits into from
Oct 19, 2023
Merged

[Screenshots] Camel K under 'How it Works See It in Action' section #5031

merged 2 commits into from
Oct 19, 2023

Conversation

singh1203
Copy link
Contributor

Description

This PR fixes #4860

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@singh1203
Added Screenshot for Camel-k
dfff209 
Signed-off-by: Saurabh Kumar Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 12, 2023

🚀 Preview for commit dfff209 at: https://652835ffbebbcf5af4470a34--layer5.netlify.app

sandramsc
sandramsc reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@sandramsc sandramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@saurabh100ni
Copy link
Contributor

Thanks for raising PR, Let's discuss this in the Website call today at 5:30 PM IST.
Please add this as your agenda in Docs

@singh1203
Copy link
Contributor Author

Thanks for raising PR, Let's discuss this in the Website call today at 5:30 PM IST. Please add this as your agenda in Docs

Sure. @saurabh100ni

@l5io
Copy link
Contributor

l5io commented Oct 16, 2023

🚀 Preview for commit ed86b2d at: https://652d74a5ef45b1405504c593--layer5.netlify.app

leecalcote
leecalcote approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you, @singh1203 👏

And for reviewing, @sandramsc 💯

@leecalcote leecalcote merged commit f2b9d17 into layer5io:master Oct 19, 2023
4 checks passed
@singh1203 singh1203 deleted the camel-k-integration branch October 20, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandramsc sandramsc sandramsc left review comments

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
project/meshery
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Screenshots] Camel K under 'How it Works See It in Action' section
5 participants
@singh1203 @l5io @saurabh100ni @leecalcote @sandramsc