Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member Profile of archit sharma added #5030

Merged
merged 4 commits into from
Oct 14, 2023
Merged

Member Profile of archit sharma added #5030

merged 4 commits into from
Oct 14, 2023

Conversation

VivekBaldha0712
Copy link
Member

@VivekBaldha0712 VivekBaldha0712 commented Oct 12, 2023 •
edited
Loading

Description

This PR fixes #5024

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

image

@l5io
Copy link
Contributor

l5io commented Oct 12, 2023

🚀 Preview for commit e183618 at: https://65280f5cb12eff3154dbbf5d--layer5.netlify.app

@EraKin575
Copy link

please put a screenshot and a change to a valid PR name.Really helps with the review

@VivekBaldha0712 VivekBaldha0712 changed the title Vivek baldha0712/5024 Member Profile of archit sharma added Oct 12, 2023
abhijeetgauravm
abhijeetgauravm reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VivekBaldha0712 some commit unrelated to the issue is also getting reflected in the PR. Rest looks good!

iArchitSharma
iArchitSharma reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@iArchitSharma iArchitSharma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there a change made to the meshery svg?

@VivekBaldha0712
Unwanted changes reverted
0a6c7a2 
Signed-off-by: VivekBaldha0712 <[email protected]>
@VivekBaldha0712
Copy link
Member Author

Reverted unwanted changes.

@l5io
Copy link
Contributor

l5io commented Oct 13, 2023

🚀 Preview for commit 0a6c7a2 at: https://6528abb930e4aa5558ba75b4--layer5.netlify.app

iArchitSharma
iArchitSharma approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abhijeetgauravm
abhijeetgauravm approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @VivekBaldha0712 . LGTM!

@abhijeetgauravm
Copy link
Contributor

LGTM

// @ritiksaxena124 @sudhanshutech

@ritiksaxena124
Copy link
Contributor

LGTM 🚀

@ritiksaxena124 ritiksaxena124 merged commit b0005f1 into layer5io:master Oct 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iArchitSharma iArchitSharma iArchitSharma approved these changes

@abhijeetgauravm abhijeetgauravm abhijeetgauravm approved these changes

Assignees
No one assigned
Labels
area/community
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Community] Member Profile: Archit Sharma
6 participants
@VivekBaldha0712 @l5io @EraKin575 @abhijeetgauravm @ritiksaxena124 @iArchitSharma