-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
program_permission_required #5022
Conversation
🚀 Preview for commit 49ea955 at: https://6525654966c52534721fd326--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add some suggestions
- Adding bullet points for the
Here’s how to get your invite:
part looks good instead of a single passage. - Changing the wording of
Participation Required Programs
/Participation Required Projects
to"Program participation required" projects
sounds more intuitive in my opinion. Similar to as mentioned in the repository overview page. Thoughts @Jat1nSood? - Some grammatical errors are present. Do proofread it once and fix them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a contributor, you should consider providing screenshots of the changes you have made. This will make the task of maintainers easier and increase the chances of your PR getting merged faster.
@Gautam-04 Understood Gautam. Will take care of that next time. |
🚀 Preview for commit 4f1dc32 at: https://652951e7047f5543af32ce42--layer5.netlify.app |
🚀 Preview for commit 7dbdd92 at: https://652a283a1393ec70f96b2d4b--layer5.netlify.app |
Hey @Jat1nSood Let's discuss this on website call tomorrow at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes. |
@Jat1nSood will you remove the unnecessary code changes? Most of what is changed is non-material to the issue at-hand. |
Hi @leecalcote , I am not sure what changes you are pointing to. Please elaborate. Do you want me to roll back to previous versions? |
@Jat1nSood You might be using any one of the formatting extensions which is causing many changes for the other parts of the file but there are only just a few lines of change. P.S. Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes. |
@Mohith234 I see, there are some extra lines and empty spaces which got added. Please confirm if those are the changes in question. Also, I am very sorry, but it is difficult for me to join at that time. I work full time and I can't join during office hours. |
@Jat1nSood Yes, due to the formatting extension there are many lines of changes happening but there is no need for it so please remove those formatting spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for seeing this through, gents.
Uh-oh, we have a merge conflict. @Jat1nSood will you investigate and reconcile? |
@Mohith234 @abhijeetgauravm Guys any idea why these checks are failing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please undo all changes not pertinent to the issue at-hand.
🚀 Preview for commit c3110c3 at: https://656de9594985f0007b201870--layer5.netlify.app |
🚀 Preview for commit 809cf05 at: https://656ebad171505c168ade0760--layer5.netlify.app |
@@ -18,58 +17,200 @@ const Faq = () => { | |||
<div className="content"> | |||
<h2 className="heading-top">General FAQs:</h2><br /> | |||
<h4>Q: Are Layer5’s solutions open source?</h4> | |||
<p>A: Yes, all Layer5 projects are licensed under Apache V2. Layer5 also offers extensions to the Meshery project in which Enterprise-centric functionality is commercially offered and supported.</p> | |||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change and others like it are unwanted. Please revert these.
Hi @leecalcote , I am not sure what happened here. |
Description
This PR fixes #4981
Notes for Reviewers
Signed commits