-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add green glow hover effect to cards #5019
Conversation
Signed-off-by: Akshun-01 <[email protected]>
🚀 Preview for commit cba501f at: https://65246bf8d921243d068d2918--layer5.netlify.app |
@Akshun-01 ensure you always link your pr to the issue, i have mentioned for now |
@@ -5,6 +5,13 @@ const CardWrapper = styled.div` | |||
min-height: 16rem; | |||
margin: auto; | |||
border-radius: 1rem; | |||
cursor: pointer; | |||
box-shadow: rgba(0, 179, 158, 0.9) 0px 2px 10px 1px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I'll look into it
@Akshun-01 checking in, any update? |
Yeah, sorry for the delay, was busy with some college work. DevOps.GitOps.and.Cloud.Native.Learning.Paths.-.Google.Chrome.2023-10-15.18-55-14.mp4 |
Signed-off-by: Akshun-01 <[email protected]>
🚀 Preview for commit 6ef47e6 at: https://652bed3503f1d66bc428e4b9--layer5.netlify.app |
@Akshun-01 the changes look great. Let's only show the green box shadow on the hover of the cards, not always. Also not show a box shadow on the "Mastering Service Meshes for Operators" card as it is not currently clickable. |
Signed-off-by: Akshun-01 <[email protected]>
Hey @ritiksaxena124, I made the required changes. DevOps.GitOps.and.Cloud.Native.Learning.Paths.-.Google.Chrome.2023-10-15.22-07-11.mp4 |
🚀 Preview for commit e7aa89b at: https://652c253b412cb31afa49ed9c--layer5.netlify.app |
Thanks for raising PR, Let's discuss this in the Website call today at 5:30 PM IST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@ritiksaxena124 are any other changes required in this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
Description
The Cards on the Learning Path page had no hover effect unlike the rest of the website
This PR fixes #4986
Added the green hover effect to the cards, similar to the pricing page cards.
Notes for Reviewers
Signed commits