Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add green glow hover effect to cards #5019

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

Akshun-01
Copy link
Contributor

@Akshun-01 Akshun-01 commented Oct 9, 2023

Description
The Cards on the Learning Path page had no hover effect unlike the rest of the website
image

This PR fixes #4986
Added the green hover effect to the cards, similar to the pricing page cards.
image

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/learn Related to /learn section label Oct 9, 2023
@l5io
Copy link
Contributor

l5io commented Oct 9, 2023

🚀 Preview for commit cba501f at: https://65246bf8d921243d068d2918--layer5.netlify.app

@sudhanshutech
Copy link
Member

@Akshun-01 ensure you always link your pr to the issue, i have mentioned for now

@@ -5,6 +5,13 @@ const CardWrapper = styled.div`
min-height: 16rem;
margin: auto;
border-radius: 1rem;
cursor: pointer;
box-shadow: rgba(0, 179, 158, 0.9) 0px 2px 10px 1px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good, but the box shadow does not have the perfect curve effect at corners if you see
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I'll look into it

@Yashsharma1911
Copy link
Member

@Akshun-01 checking in, any update?

@Akshun-01
Copy link
Contributor Author

Yeah, sorry for the delay, was busy with some college work.
This is the latest one, I altered the glow effect so that it looks better with curved edges as requested. You can review the changes

DevOps.GitOps.and.Cloud.Native.Learning.Paths.-.Google.Chrome.2023-10-15.18-55-14.mp4

@l5io
Copy link
Contributor

l5io commented Oct 15, 2023

🚀 Preview for commit 6ef47e6 at: https://652bed3503f1d66bc428e4b9--layer5.netlify.app

@ritiksaxena124
Copy link
Contributor

@Akshun-01 the changes look great. Let's only show the green box shadow on the hover of the cards, not always. Also not show a box shadow on the "Mastering Service Meshes for Operators" card as it is not currently clickable.

@Akshun-01
Copy link
Contributor Author

Hey @ritiksaxena124, I made the required changes.

DevOps.GitOps.and.Cloud.Native.Learning.Paths.-.Google.Chrome.2023-10-15.22-07-11.mp4

@l5io
Copy link
Contributor

l5io commented Oct 15, 2023

🚀 Preview for commit e7aa89b at: https://652c253b412cb31afa49ed9c--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

Thanks for raising PR, Let's discuss this in the Website call today at 5:30 PM IST.
Please add this as your agenda in Docs

Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Akshun-01
Copy link
Contributor Author

@ritiksaxena124 are any other changes required in this?

Copy link
Contributor

@ritiksaxena124 ritiksaxena124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@ritiksaxena124 ritiksaxena124 merged commit 4879377 into layer5io:master Oct 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/learn Related to /learn section
Development

Successfully merging this pull request may close these issues.

[UI] No Hover Effect on Cards
7 participants