Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'How it Works See It in Action' Section #4958

Merged
merged 13 commits into from
Nov 8, 2023

Conversation

coder12git
Copy link
Member

@coder12git coder12git commented Sep 23, 2023

Description

This PR related to #4882

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Sep 23, 2023

🚀 Preview for commit 809ef21 at: https://650f3aadcb64f65eedb9faf9--layer5.netlify.app

@coder12git
Copy link
Member Author

coder12git commented Sep 24, 2023

Hey @saurabh100ni, as I am new to Laye5, that's why I was confused about what screenshots/videos need to be added, that's why I have added few of them that feels right to me. Please let me know if I need to do any changes.

@saurabh100ni
Copy link
Contributor

@Rajdip019 can you review? 👀

@Rajdip019
Copy link

Screenshot 2023-09-24 at 10 56 19 AM

There is a little alignment issue for the preview screens on the right. It would be better if we align it it make it in the middle horizontally. @coder12git

@coder12git
Copy link
Member Author

Screenshot 2023-09-24 at 10 56 19 AM There is a little alignment issue for the preview screens on the right. It would be better if we align it it make it in the middle horizontally. @coder12git

Ok, I will do that, but the screenshots/videos that I have added, is it fine?

@Rajdip019
Copy link

Yes about that -

  • Add both Dark Mode and Light Mode screenshots.
  • The screenshot should not be a snippet, take the full screenshot of your browser.
  • Use Incognito mode on Chrome browser, to ensure your bookmark bar or any other items are not shown in the screenshot/video.

Signed-off-by: coder12git <[email protected]>
Signed-off-by: coder12git <[email protected]>
@coder12git
Copy link
Member Author

Yes about that -

  • Add both Dark Mode and Light Mode screenshots.
  • The screenshot should not be a snippet, take the full screenshot of your browser.
  • Use Incognito mode on Chrome browser, to ensure your bookmark bar or any other items are not shown in the screenshot/video.

Ok, so I have done all changes, also I didn't get any screenshot for crossplane integrations.

@saurabh100ni
Copy link
Contributor

let's discuss that too on today's website meeting,
please add this agenda in the docs: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.69qskjv558bk

@coder12git
Copy link
Member Author

let's discuss that too on today's website meeting, please add this agenda in the docs: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.69qskjv558bk

Done!

Signed-off-by: coder12git <[email protected]>
@coder12git
Copy link
Member Author

let's discuss that too on today's website meeting, please add this agenda in the docs: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.69qskjv558bk

Done!
Hey @saurabh100ni I was wondering, when I will get demo video which will tell about crossplane integration, as discussed in the last meet.

@saurabh100ni
Copy link
Contributor

@sudhanshutech //

@coder12git
Copy link
Member Author

@sudhanshutech //

Any update on this?

This reverts commit 1c00d63.

Signed-off-by: coder12git <[email protected]>
This reverts commit 8629670.

Signed-off-by: coder12git <[email protected]>
This reverts commit 809ef21.

Signed-off-by: coder12git <[email protected]>
This reverts commit 474f743.

Signed-off-by: coder12git <[email protected]>
Signed-off-by: coder12git <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 1, 2023

🚀 Preview for commit 9afa436 at: https://6519b89d08627f7840672322--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Nov 6, 2023

🚀 Preview for commit c25f4cd at: https://6548f743bd633e0a6475101c--layer5.netlify.app

@sudhanshutech sudhanshutech merged commit 0ef238b into layer5io:master Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants