Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding-issue-valid-functionality #4957

Closed
wants to merge 6 commits into from

Conversation

PRANJALRANA11
Copy link
Contributor

@PRANJALRANA11 PRANJALRANA11 commented Sep 23, 2023

Description

This PR fixes #4933

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Sep 23, 2023

🚀 Preview for commit 7f44154 at: https://650f074e5abffc3ce7699e79--layer5.netlify.app

@PRANJALRANA11
Copy link
Contributor Author

@leecalcote please review the changes

@saurabh100ni
Copy link
Contributor

let's discuss this item on today's website meeting,
please add this agenda in the docs: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.69qskjv558bk

Signed-off-by: Pranjal Rana <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 27, 2023

🚀 Preview for commit f83368c at: https://651440cbd4ade4008fefbb9d--layer5.netlify.app

@sandramsc
Copy link
Member

sandramsc commented Sep 27, 2023

Looks good @PRANJALRANA11, workflow includes support for issue/valid and help wanted.I also used YAMLlint to check validation of the .yml file 👍🏽

I've left a few inline comments as suggestions to increase the readability and flow of some of the text.

@leecalcote
Copy link
Member

@sandramsc any grammatical corrections that you might suggest or rephrasing is most welcomed.

@sandramsc
Copy link
Member

@sandramsc any grammatical corrections that you might suggest or rephrasing is most welcomed.

Hi Lee, yes, I've added some inline comments with suggestions. 👍🏽

PRANJALRANA11 and others added 2 commits September 28, 2023 11:52
Co-authored-by: Sandra Ashipala <[email protected]>
Signed-off-by: Pranjal Rana <[email protected]>
Co-authored-by: Sandra Ashipala <[email protected]>
Signed-off-by: Pranjal Rana <[email protected]>
@PRANJALRANA11
Copy link
Contributor Author

@sandramsc commited that

@PRANJALRANA11
Copy link
Contributor Author

@leecalcote will this be good to merge

@leecalcote
Copy link
Member

@leecalcote will this be good to merge

Almost. The suggestion verbiage needs refinement.

Signed-off-by: Pranjal Rana <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 1, 2023

🚀 Preview for commit 4c5c307 at: https://6518edd058a2270c7fa4725f--layer5.netlify.app

@PRANJALRANA11
Copy link
Contributor Author

is this refinement good or do i have to add some more

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PRANJALRANA11, I'll offer a final round of feedback. If the next review requires more changes, let's closeout this PR and allow you to move onto another issue.

  1. "You may now proceed with appropriate actions based on the provided issue description"

No, this is inaccurate.

  1. The issue doesn't ask for a comment to be added on application of a "help wanted" label. Thanks for making consideration for one, however, this enhancement isn't desired.

@PRANJALRANA11 PRANJALRANA11 deleted the temp branch October 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

[CI] Label Commenter for new GH issue label: "issue/valid"
5 participants