-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding-issue-valid-functionality #4957
Conversation
Signed-off-by: Pranjal Rana <[email protected]>
Signed-off-by: Pranjal Rana <[email protected]>
🚀 Preview for commit 7f44154 at: https://650f074e5abffc3ce7699e79--layer5.netlify.app |
@leecalcote please review the changes |
let's discuss this item on today's website meeting, |
Signed-off-by: Pranjal Rana <[email protected]>
🚀 Preview for commit f83368c at: https://651440cbd4ade4008fefbb9d--layer5.netlify.app |
Looks good @PRANJALRANA11, workflow includes support for issue/valid and help wanted.I also used YAMLlint to check validation of the .yml file 👍🏽 I've left a few inline comments as suggestions to increase the readability and flow of some of the text. |
@sandramsc any grammatical corrections that you might suggest or rephrasing is most welcomed. |
Hi Lee, yes, I've added some inline comments with suggestions. 👍🏽 |
Co-authored-by: Sandra Ashipala <[email protected]> Signed-off-by: Pranjal Rana <[email protected]>
Co-authored-by: Sandra Ashipala <[email protected]> Signed-off-by: Pranjal Rana <[email protected]>
@sandramsc commited that |
@leecalcote will this be good to merge |
Almost. The suggestion verbiage needs refinement. |
Signed-off-by: Pranjal Rana <[email protected]>
🚀 Preview for commit 4c5c307 at: https://6518edd058a2270c7fa4725f--layer5.netlify.app |
is this refinement good or do i have to add some more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PRANJALRANA11, I'll offer a final round of feedback. If the next review requires more changes, let's closeout this PR and allow you to move onto another issue.
- "You may now proceed with appropriate actions based on the provided issue description"
No, this is inaccurate.
- The issue doesn't ask for a comment to be added on application of a "help wanted" label. Thanks for making consideration for one, however, this enhancement isn't desired.
Description
This PR fixes #4933
Notes for Reviewers
Signed commits