Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Updated Newcomers page mascot image #4935

Merged
merged 3 commits into from
Sep 23, 2023
Merged

Fix: Updated Newcomers page mascot image #4935

merged 3 commits into from
Sep 23, 2023

Conversation

akhilender-bongirwar
Copy link
Member

Description

  • Replaced the outdated version of Five, our stick figure mascot, on the Newcomers page.
  • The new mascot image has been selected from the available updated versions provided under https://layer5.io/brand.

This PR fixes #4929

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@akhilender-bongirwar
Fix: Updated Newcomers page mascot image
bdf8c7b 
- Replaced the outdated version of Five, our stick figure mascot, on the Newcomers page.
- The new mascot image has been selected from the available updated versions provided under https://layer5.io/brand.

Fixes issue layer5io#4929

Signed-off-by: Akhilender <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 21, 2023

🚀 Preview for commit bdf8c7b at: https://650c080e0a9f9d02d83a2978--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

@Rajdip019 Up for review 👀

@Rajdip019
Copy link

@akhilender-bongirwar if contributor-chest-colorMode.svg is not getting used anywhere then we can remove that. Everything else looks fine.

@akhilender-bongirwar
Copy link
Member Author

Yeah contributor-chest-colorMode.svg , contributor-chest-white.svg and contributor-chest.svg are not getting used anywhere.
Should I remove all of them?

//@Rajdip019

@Rajdip019
Copy link

Yeah contributor-chest-colorMode.svg , contributor-chest-white.svg and contributor-chest.svg are not getting used anywhere. Should I remove all of them?

//@Rajdip019

Yes, it's better to remove them. As the svgs are updated with new ones.

@l5io
Copy link
Contributor

l5io commented Sep 21, 2023

🚀 Preview for commit 98394d9 at: https://650c9690ec18021f525a859c--layer5.netlify.app

@akhilender-bongirwar
Copy link
Member Author

Hey @Rajdip019, removed all the old svg files. Could you please review this PR : )

Mohith234
Mohith234 reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo looks good in light mode, what about the dark mode? Do we have any other mascot logo for the dark mode to look better? @akhilender-bongirwar

image

@akhilender-bongirwar
Copy link
Member Author

I see no problem with the looks of the logo even in the dark mode; it looks great IMO. //@Mohith234
Please any other opinions on the change of the logo for the dark mode would be appreciated greatly. // @Rajdip019

@Rajdip019
Copy link

The logo in dark mode looks good to me as well.

@akhilender-bongirwar
Copy link
Member Author

Thank you for the immediate feedback @Rajdip019 : )

@leecalcote leecalcote merged commit f53bbc6 into layer5io:master Sep 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohith234 Mohith234 Mohith234 left review comments

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Community] Newcomers: Update mascot image
6 participants
@akhilender-bongirwar @l5io @saurabh100ni @Rajdip019 @leecalcote @Mohith234