-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Five and Friends CTA to column of widgets #4930
Conversation
Signed-off-by: Tothagata Bhattacharjee <[email protected]>
🚀 Preview for commit a46b587 at: https://6508a8feef6fec3f23b2c425--layer5.netlify.app |
@@ -9,6 +9,7 @@ import { HiOutlineChevronDown } from "@react-icons/all-files/hi/HiOutlineChevron | |||
// import { FaSearch } from "@react-icons/all-files/fa/FaSearch"; | |||
|
|||
const Discuss = "../../../assets/images/discuss/layer5-discuss-white.webp"; | |||
const FiveandFriendsAdventures = "../../../assets/images/blog/five-and-friends.png"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just use the already present one instead of adding another new image of the Five and Friends
?
What do you think @toth2000?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mohith234 are you referring to the image src\assets\images\adventure-five\layer_five.png
?
Both the images have different texts on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, IMO that text represented a bit more intuitive as a CTA. But yeah I saw the mockup has this image you've used so it's ok 👍 @toth2000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritiksaxena124 Which one do you think is good? Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritiksaxena124 @Mohith234 updated the image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good in preview but need some enhancement!
Signed-off-by: Tothagata Bhattacharjee <[email protected]>
🚀 Preview for commit fcb3af9 at: https://65095fcde988622fd7e70962--layer5.netlify.app |
Signed-off-by: Tothagata Bhattacharjee <[email protected]>
🚀 Preview for commit 9e04a4f at: https://65097cd5ef6fec4473b2c520--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you, gents. 👏 |
Signed-off-by: Lee Calcote <[email protected]>
Thank you, gents. 👏 |
Description
This PR fixes #4916
Notes for Reviewers
Signed commits