Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the Line height issue in Five and Friends CTA #4923

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Fixing the Line height issue in Five and Friends CTA #4923

merged 2 commits into from
Sep 22, 2023

Conversation

VamshiReddy02
Copy link
Contributor

Description

This PR fixes #4915

Notes for Reviewers
I reduced the "line-height" in Five and Friends CTA. Please let me know if there are any changes to be made.

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Sep 16, 2023

🚀 Preview for commit d3b5a8f at: https://6505784fe9886275e5e70962--layer5.netlify.app

abhijeetgauravm
abhijeetgauravm approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@Ghat0tkach
Copy link
Member

hey @VamshiReddy02
Let's discuss it on the websites call.
I have already added your agenda as part of today's meeting minutes

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@VamshiReddy02
Copy link
Contributor Author

Hey @Chadha93, and @leecalcote, can you review this PR, and let me know of any changes?

leecalcote
leecalcote approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Thanks, @VamshiReddy02

@leecalcote leecalcote merged commit c7d7344 into layer5io:master Sep 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijeetgauravm abhijeetgauravm abhijeetgauravm approved these changes

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Community] Line height issue in Five and Friends CTA
5 participants
@VamshiReddy02 @l5io @Ghat0tkach @leecalcote @abhijeetgauravm