Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding-badges-section-in-newcomers-members-page #4895

Closed
wants to merge 8 commits into from

Conversation

PRANJALRANA11
Copy link
Contributor

@PRANJALRANA11 PRANJALRANA11 commented Sep 10, 2023

Description
I have added in both pages
image

and i have updated the image align
image

This PR fixes #4892

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@PRANJALRANA11
Copy link
Contributor Author

@leecalcote I have added the necessary changes

@l5io
Copy link
Contributor

l5io commented Sep 10, 2023

🚀 Preview for commit 5210a1a at: https://64fd548261818b681c9fda26--layer5.netlify.app

@Ghat0tkach
Copy link
Member

hey @PRANJALRANA11

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@leecalcote
Copy link
Member

@ShravaniAK will you review this PR?

Copy link
Contributor

@ShravaniAK ShravaniAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PRANJALRANA11 It would be better if the text and heading align, and also there is alignment issue in images. Also currently it is not mobile-responsive.

@PRANJALRANA11
Copy link
Contributor Author

@ShravaniAK ok sure I will do it

Signed-off-by: PRANJALRANA11 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 13, 2023

🚀 Preview for commit 14f027b at: https://65012e3dceeaf62b3fe0bfb6--layer5.netlify.app

@PRANJALRANA11
Copy link
Contributor Author

@ShravaniAK please review the changes

@ShravaniAK
Copy link
Contributor

Looking great now !!

@PRANJALRANA11
Copy link
Contributor Author

@leecalcote could you merge this

Signed-off-by: PRANJALRANA11 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 14, 2023

🚀 Preview for commit 5234610 at: https://650324b7bccfc70336a75543--layer5.netlify.app

@PRANJALRANA11
Copy link
Contributor Author

@Chadha93 i have fix it

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please shrink the image size at each breakpoint.
Please keep the image with the text, wrapping the text around the image in mobile view.

Screenshot 2023-09-15 at 12 08 39 PM

@PRANJALRANA11
Copy link
Contributor Author

@leecalcote fixed that in mobile view

Signed-off-by: PRANJALRANA11 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 16, 2023

🚀 Preview for commit 44b0b36 at: https://6505cd81a20b4e2a3a8ee5f6--layer5.netlify.app

Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PRANJALRANA11
Copy link
Contributor Author

@leecalcote is this good to merge

@leecalcote
Copy link
Member

@leecalcote is this good to merge

Unfortunately, no. This is taking more reviews than it should.

@l5io
Copy link
Contributor

l5io commented Oct 3, 2023

🚀 Preview for commit d0641ca at: https://651c781e45250a1b317d5d31--layer5.netlify.app

@PRANJALRANA11
Copy link
Contributor Author

it's failing the install and build job

@leecalcote
Copy link
Member

@PRANJALRANA11 that means that a bug has crept in. I'll let you fix.

@l5io
Copy link
Contributor

l5io commented Oct 4, 2023

🚀 Preview for commit 7c514df at: https://651cf2d48306007d8360c41f--layer5.netlify.app

@PRANJALRANA11
Copy link
Contributor Author

What was the bug

@l5io
Copy link
Contributor

l5io commented Nov 6, 2023

🚀 Preview for commit 5c76bea at: https://65488781f1655163cd2623c4--layer5.netlify.app

@sudhanshutech
Copy link
Member

@PRANJALRANA11 are you still there? at newcomers page the image getting pressed
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add Mention of Badges Site to Layer5.io Pages
8 participants