-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding-badges-section-in-newcomers-members-page #4895
Conversation
Signed-off-by: PRANJALRANA11 <[email protected]>
@leecalcote I have added the necessary changes |
🚀 Preview for commit 5210a1a at: https://64fd548261818b681c9fda26--layer5.netlify.app |
hey @PRANJALRANA11 Let's discuss it on the websites call. |
@ShravaniAK will you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PRANJALRANA11 It would be better if the text and heading align, and also there is alignment issue in images. Also currently it is not mobile-responsive.
@ShravaniAK ok sure I will do it |
Signed-off-by: PRANJALRANA11 <[email protected]>
🚀 Preview for commit 14f027b at: https://65012e3dceeaf62b3fe0bfb6--layer5.netlify.app |
@ShravaniAK please review the changes |
Looking great now !! |
@leecalcote could you merge this |
Signed-off-by: PRANJALRANA11 <[email protected]>
🚀 Preview for commit 5234610 at: https://650324b7bccfc70336a75543--layer5.netlify.app |
@Chadha93 i have fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leecalcote fixed that in mobile view |
Signed-off-by: PRANJALRANA11 <[email protected]>
🚀 Preview for commit 44b0b36 at: https://6505cd81a20b4e2a3a8ee5f6--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@leecalcote is this good to merge |
Unfortunately, no. This is taking more reviews than it should. |
Signed-off-by: Lee Calcote <[email protected]>
🚀 Preview for commit d0641ca at: https://651c781e45250a1b317d5d31--layer5.netlify.app |
Signed-off-by: PRANJALRANA11 <[email protected]>
… into adding-badges
it's failing the install and build job |
@PRANJALRANA11 that means that a bug has crept in. I'll let you fix. |
🚀 Preview for commit 7c514df at: https://651cf2d48306007d8360c41f--layer5.netlify.app |
What was the bug |
🚀 Preview for commit 5c76bea at: https://65488781f1655163cd2623c4--layer5.netlify.app |
@PRANJALRANA11 are you still there? at newcomers page the image getting pressed |
Description
I have added in both pages
and i have updated the image align
This PR fixes #4892
Notes for Reviewers
Signed commits