Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding -badges-info-to-newcomer-section #4893

Closed
wants to merge 5 commits into from

Conversation

PRANJALRANA11
Copy link
Contributor

@PRANJALRANA11 PRANJALRANA11 commented Sep 9, 2023

Description
added the badges recogniton information

image

This PR fixes #4892

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: PRANJALRANA11 <[email protected]>
Signed-off-by: PRANJALRANA11 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 9, 2023

🚀 Preview for commit 64ba306 at: https://64fc1a3a07d1233258244c20--layer5.netlify.app

@leecalcote
Copy link
Member

Some good stuff here, @PRANJALRANA11

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PRANJALRANA11, great work. I have suggested a few tweaks. We'll be good to merge once those are accepted and you have sync'ed your fork in order to avoid include commits from others or commits intended for other PRs. This PR should only include your commits / commits for the issue at-hand.

src/sections/Community/Newcomers-guide/index.js Outdated Show resolved Hide resolved
src/sections/Community/Newcomers-guide/index.js Outdated Show resolved Hide resolved
src/sections/Community/Newcomers-guide/index.js Outdated Show resolved Hide resolved
src/sections/Community/Newcomers-guide/index.js Outdated Show resolved Hide resolved
src/sections/Community/Newcomers-guide/index.js Outdated Show resolved Hide resolved
src/sections/Community/Newcomers-guide/index.js Outdated Show resolved Hide resolved
@PRANJALRANA11
Copy link
Contributor Author

@leecalcote ok sure

@l5io
Copy link
Contributor

l5io commented Sep 9, 2023

🚀 Preview for commit 95f8b57 at: https://64fcb799d0af9f16b66bc5c2--layer5.netlify.app

@leecalcote
Copy link
Member

I have merged all the suggestions.

@abhijeetgauravm
Copy link
Contributor

won't it look much good if the badge would lie little above! Thoughts?
image

@leecalcote
Copy link
Member

@abhijeetgauravm, yes, I believe that you are right.

@PRANJALRANA11
Copy link
Contributor Author

@abhijeetgauravm you are right

@l5io
Copy link
Contributor

l5io commented Sep 10, 2023

🚀 Preview for commit 9bc596b at: https://64fd3ce7ece3555d21c20425--layer5.netlify.app

@Ghat0tkach
Copy link
Member

hey @PRANJALRANA11

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@ritiksaxena124
Copy link
Contributor

Also, the badge is being cut off from the sides.

@PRANJALRANA11
Copy link
Contributor Author

@ritiksaxena124 I had made another pr

@Chadha93
Copy link
Member

@ritiksaxena124 I had made another pr

@PRANJALRANA11 You can close this duplicate PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add Mention of Badges Site to Layer5.io Pages
7 participants