-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding -badges-info-to-newcomer-section #4893
Conversation
Signed-off-by: PRANJALRANA11 <[email protected]>
Signed-off-by: PRANJALRANA11 <[email protected]>
Signed-off-by: PRANJALRANA11 <[email protected]>
🚀 Preview for commit 64ba306 at: https://64fc1a3a07d1233258244c20--layer5.netlify.app |
Some good stuff here, @PRANJALRANA11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PRANJALRANA11, great work. I have suggested a few tweaks. We'll be good to merge once those are accepted and you have sync'ed your fork in order to avoid include commits from others or commits intended for other PRs. This PR should only include your commits / commits for the issue at-hand.
@leecalcote ok sure |
Signed-off-by: Lee Calcote <[email protected]>
🚀 Preview for commit 95f8b57 at: https://64fcb799d0af9f16b66bc5c2--layer5.netlify.app |
I have merged all the suggestions. |
@abhijeetgauravm, yes, I believe that you are right. |
@abhijeetgauravm you are right |
🚀 Preview for commit 9bc596b at: https://64fd3ce7ece3555d21c20425--layer5.netlify.app |
hey @PRANJALRANA11 Let's discuss it on the websites call. |
Also, the badge is being cut off from the sides. |
@ritiksaxena124 I had made another pr |
@PRANJALRANA11 You can close this duplicate PR then. |
Description
added the badges recogniton information
This PR fixes #4892
Notes for Reviewers
Signed commits