-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes [Newsletter Alignment] Center-align "Subscribe to our Newsletter" #4889
Conversation
Previously this Subscribe to our Newsletter is to the right of the page which is not good actually so I changed it to the center page which increases UX(user experience) Signed-off-by: Kotiswar <[email protected]>
I fixed this bug where the footer subscribe news letter is aligned to the end but I made it to align to the center Signed-off-by: Kotiswar <[email protected]>
🚀 Preview for commit 13b6ef4 at: https://64fa55c444ff32007ce93bab--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick heads up @Kkotiswar. The issue is neither approved as valid nor assigned to you.
Please be patient until the maintainers respond. Creating PRs without getting assigned is completely against the contributing guidelines. Also, it is not a good practice.
Follow the contributing guidelines or else your work will not be considered.
Sorry for the inconvenience I thought this issue is valid and it hasnt been assigned to anyone so I thought of giving it a try. |
Signed-off-by: Kotiswar <[email protected]>
🚀 Preview for commit 387c650 at: https://64fb0eaa7c8f0978590d40fc--layer5.netlify.app |
Thanks @Kkotiswar for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 @Kkotiswar
P.S Please do follow the contributing guidelines
Certainly, I acknowledge and appreciate your reminder to follow the contributing guidelines. Rest assured, I will diligently adhere to the guidelines from now on. Thank you for the guidance, and I look forward to contributing positively to the community. |
hey @Kkotiswar |
Hi @Ghat0tkach, I've created an agenda item for the upcoming website call regarding the pull request I submitted. Thanks! |
@Kkotiswar what were the results of the poll that you've conducted? Please post an update so that we can complete this issue as soon as possible. |
|
@Kkotiswar No one has voted really and I think let's keep the design as it is in the current website. Wdyt? Let's close this issue as soon as possible |
Closing as this is not planned. |
Description
This pull request addresses the bug where the "Subscribe to our Newsletter" element is currently right-aligned and should be centered.
previously ->
After Fix ->
This PR fixes #4822
Notes for Reviewers
Signed commits