Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes [Newsletter Alignment] Center-align "Subscribe to our Newsletter" #4889

Closed
wants to merge 3 commits into from

Conversation

Kkotiswar
Copy link

Description
This pull request addresses the bug where the "Subscribe to our Newsletter" element is currently right-aligned and should be centered.
previously ->
image
After Fix ->
image

This PR fixes #4822

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Previously this Subscribe to our Newsletter is to the right of the page which is not good actually so I changed it to the center page which increases UX(user experience)

Signed-off-by: Kotiswar <[email protected]>
I fixed this bug where the footer subscribe news letter is aligned to the end but I made it to align to the center

Signed-off-by: Kotiswar <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 7, 2023

🚀 Preview for commit 13b6ef4 at: https://64fa55c444ff32007ce93bab--layer5.netlify.app

Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick heads up @Kkotiswar. The issue is neither approved as valid nor assigned to you.

Please be patient until the maintainers respond. Creating PRs without getting assigned is completely against the contributing guidelines. Also, it is not a good practice.

Follow the contributing guidelines or else your work will not be considered.

@Kkotiswar
Copy link
Author

Kkotiswar commented Sep 8, 2023

A quick heads up @Kkotiswar. The issue is neither approved as valid nor assigned to you.

Please be patient until the maintainers respond. Creating PRs without getting assigned is completely against the contributing guidelines. Also, it is not a good practice.

Follow the contributing guidelines or else your work will not be considered.

Sorry for the inconvenience I thought this issue is valid and it hasnt been assigned to anyone so I thought of giving it a try.

Signed-off-by: Kotiswar <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 8, 2023

🚀 Preview for commit 387c650 at: https://64fb0eaa7c8f0978590d40fc--layer5.netlify.app

@vishalvivekm
Copy link
Member

Thanks @Kkotiswar for this.
Please do take a look: #4822 (comment)

Mohith234

This comment was marked as resolved.

Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 @Kkotiswar

P.S Please do follow the contributing guidelines

@Kkotiswar
Copy link
Author

Certainly, I acknowledge and appreciate your reminder to follow the contributing guidelines. Rest assured, I will diligently adhere to the guidelines from now on. Thank you for the guidance, and I look forward to contributing positively to the community.

@Ghat0tkach
Copy link
Member

hey @Kkotiswar
Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@Kkotiswar
Copy link
Author

Hi @Ghat0tkach,

I've created an agenda item for the upcoming website call regarding the pull request I submitted.

Thanks!

@Mohith234
Copy link
Member

@Kkotiswar what were the results of the poll that you've conducted? Please post an update so that we can complete this issue as soon as possible.

@Kkotiswar
Copy link
Author

@Kkotiswar what were the results of the poll that you've conducted? Please post an update so that we can complete this issue as soon as possible.

Yeah, these are the results for the poll I have created.
Screenshot_2023-09-28-19-58-43-218-edit_com brave browser

@Mohith234
Copy link
Member

@Kkotiswar No one has voted really and I think let's keep the design as it is in the current website. Wdyt?

Let's close this issue as soon as possible

@Mohith234
Copy link
Member

Closing as this is not planned.

@Mohith234 Mohith234 closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Misalignment in
5 participants