Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Event: IstioCon Virtual 2023 #4762

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

malaviya-parth
Copy link
Contributor

Description

This PR fixes #4756

Notes for Reviewers

  • Have added a link tag register here below the text
  • Image resolution is the default provided

Signed commits

  • Yes, I signed my commits.

@Chadha93
Copy link
Member

Thanks for the PR @malaviya-parth.

Will be merged after the 21st.

@l5io
Copy link
Contributor

l5io commented Aug 18, 2023

🚀 Preview for commit b6f140e at: https://64dfab776d07a002ea7bce85--layer5.netlify.app

Copy link
Member

@hirentimbadiya hirentimbadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malaviya-parth, please undo the changes you made in package-lock.json file.

Made it like before

Signed-off-by: Parth Malaviya <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 19, 2023

🚀 Preview for commit 336d5b1 at: https://64e059acc07fa023080ce179--layer5.netlify.app

@Ghat0tkach
Copy link
Member

@malaviya-parth @Chadha93

The PR looks good however a few enhancement needs to be done on the thumbnail image
image

//
If we can alter-image , otherwise everything is Good⭐
It would be nice if the thumbnail image is
image

@malaviya-parth
Copy link
Contributor Author

@Ghat0tkach
So should I change it with the image you provided? or wait for @Chadha93 's confirmation?

@Ghat0tkach
Copy link
Member

@malviya-parth lets wait for his confirmation😅

@Ghat0tkach
Copy link
Member

hey @malaviya-parth

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@malaviya-parth
Copy link
Contributor Author

hey @malaviya-parth

Let's discuss it on the websites call. Please add this as an agenda item in the meeting minutes, if you would :)

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

Sorry I was not able to make it to the meeting due to some work, If any changes are required can you tell me. Once Again sorry for not attending.

@Chadha93
Copy link
Member

hey @malaviya-parth
Let's discuss it on the websites call. Please add this as an agenda item in the meeting minutes, if you would :)
docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

Sorry I was not able to make it to the meeting due to some work, If any changes are required can you tell me. Once Again sorry for not attending.

@malaviya-parth, Will you please update the thumbnail with the image @Ghat0tkach, provided?

Signed-off-by: Ritik Saxena <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 23, 2023

🚀 Preview for commit 637e02f at: https://64e64c3ef7d9ad04784e5bae--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 23, 2023

🚀 Preview for commit b9ae0de at: https://64e657b0551e6411acc0d812--layer5.netlify.app

@Chadha93 Chadha93 merged commit 8ba0c18 into layer5io:master Aug 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Event] Add new event IstioCon Virtual 2023
6 participants