Updated the Twiiter Logo to X Logo #4755
Conversation
Signed-off-by: Navansh Khandelwal <[email protected]>
|
🚀 Preview for commit 963a953 at: https://64df6575cb5135065756d4ed--layer5.netlify.app |
There was a problem hiding this comment.
Looks good @Navansh but also need to update in commmunity handbook page , community members page etc wherever there is old twitter logo.
There was a problem hiding this comment.
@Navansh, kindly replace old twitter logo in following pages :
- in community members page.
- in community handbook page.
- also replace in other pages if there is old twitter logo being used.
There was a problem hiding this comment.
Code Review - Pull Request #4755: Updated the Twitter Logo to X Logo
- The update to the X logo has been successfully updated.
- The new X logo matches the current branding and design of "Twitter".
- The code changes appear clean and follow the coding standards.
Should I create a new PR for this ? |
|
hey @Navansh Let's discuss it on the websites call. |
|
🚀 Preview for commit d920344 at: https://64e59421315b7f1b5ad5b62a--layer5.netlify.app |
|
@Navansh Few items left... |
|
hii @Navansh |
Sure, when is the call ? |
hey navansh just add to your calendar https://layer5.io/community/calendar , btw websites weekly call takes place on every Monday 5:30 pm IST. |
|
@Navansh updates? |
|
How do I find the file where the Twitter logo is put for the page : |
|
🚀 Preview for commit c582083 at: https://64f5d407f0d5a7433f900118--layer5.netlify.app |
There was a problem hiding this comment.
@Navansh Here's the single member profile's link where you can find Twitter icon.
.
|
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
|
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
Signed-off-by: Navansh Khandelwal <[email protected]>
|
🚀 Preview for commit f61c53c at: https://6511834070ade61f67c634bc--layer5.netlify.app |
There was a problem hiding this comment.
@Navansh There are some changes that need to be done, I've listed them here. Do look into them
- The logo is not visible in the light mode. ( In each page where it is modified )
- On the community members page, the logo isn't visible whenever we hover on top of it.
- Remove the imports of the previously used Twitter icon on the single member's profile pages.
- Please signoff your commits so that the DCO check don't get failed
Well, how do I enable Twitter logo for both dark and light mode ? |
|
@ritiksaxena124 ^^ might help you here. |
|
is this what we want to achieve :- Screencast.from.2023-10-02.23-46-56.webm |
yes @captain-Akshay you are on the right path could you please make sure all the icons are of the same size? |
|
@ritiksaxena124 should I work on my own pr or suggest some changes to current one(this will take more time to setup) |
|
@captain-Akshay you can work on your own PR as @Navansh is inactive due to his other commitments, you are welcome to create a PR as soon as possible. So that we can fix this issue and close it |
|
@Mohith234 Alright 👍🏻 assign it to me |
|
Closing it as the issue is fixed by #5001. Thanks for the contribution. |
Description
This PR fixes #4631
Notes for Reviewers
Updated the Twiiter Logo, to the new X Logo
Signed commits