Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:added blog for meshmap #4537

Closed
wants to merge 17 commits into from
Closed

feat:added blog for meshmap #4537

wants to merge 17 commits into from

Conversation

Ghat0tkach
Copy link
Member

Description

This PR fixes #4520

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/blog New posts or new blog functionality label Jul 13, 2023
@Ghat0tkach Ghat0tkach marked this pull request as draft July 13, 2023 11:32
@Ghat0tkach Ghat0tkach marked this pull request as ready for review July 13, 2023 11:39
@l5io
Copy link
Contributor

l5io commented Jul 13, 2023

🚀 Preview for commit f10913f at: https://64afe46fa7039811efbfd09c--layer5.netlify.app

theBeginner86
theBeginner86 reviewed Jul 13, 2023
View reviewed changes
src/collections/blog/2023/2023-7-13-meshmap-guide-for-newcomers/index.mdx Outdated
<h2>How to access Meshmap?</h2>
<p>Visit the <a href="https://play.meshery.io/">Playground</a> and enter your credentials for the early access. Meshmap is an integrated part of meshery-cloud. Access to the Playground will be granted to you through your email at the soonest opportunity.</p>

<h2>Why Meshmap??</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2>Why Meshmap??</h2>
<h2>Why Meshmap?</h2>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize both “m”s

Copy link
Member Author

@Ghat0tkach Ghat0tkach Jul 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @theBeginner86 , On my way @leecalcote

Ghat0tkach and others added 2 commits July 13, 2023 17:27
@Ghat0tkach @theBeginner86
feat: added meshmap blog
0ee3623 
Co-authored-by: Pranav Singh <[email protected]>
Signed-off-by: Vikramaditya Singh <[email protected]>
@Ghat0tkach
Update index.mdx
ae237b1 
Signed-off-by: Vikramaditya Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 13, 2023

🚀 Preview for commit ae237b1 at: https://64afef83d035c316d7606ef3--layer5.netlify.app

hirentimbadiya
hirentimbadiya reviewed Jul 15, 2023
View reviewed changes
Copy link
Member

@hirentimbadiya hirentimbadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also specify an 'alt' tag in the 'img' attribute to provide alternative text for the images. Other than that, everything looks good to merge.

@Ghat0tkach
feat:added alt-tags
fca2a8f 
Signed-off-by: Vikramaditya Singh <[email protected]>
@Ghat0tkach
Copy link
Member Author

We can also specify an 'alt' tag in the 'img' attribute to provide alternative text for the images. Other than that, everything looks good to merge.

Thank you for the feedback , added the alt tags as well!

@l5io
Copy link
Contributor

l5io commented Jul 15, 2023

🚀 Preview for commit fca2a8f at: https://64b27f049a72cb7a84efdf80--layer5.netlify.app

@vishalvivekm
Copy link
Member

@Ghat0tkach

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)

@Ghat0tkach
Update index.mdx
e4d0a27 
Signed-off-by: Vikramaditya Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 17, 2023

🚀 Preview for commit e4d0a27 at: https://64b520cd8d78930f097ffe5b--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jul 25, 2023

🚀 Preview for commit f2f7924 at: https://64bfe08caf115303a20837db--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jul 25, 2023

🚀 Preview for commit f2f7924 at: https://64bfe0e4679db90b0e277ca3--layer5.netlify.app

Chadha93
Chadha93 suggested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@Chadha93 Chadha93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ghat0tkach, You can add links to meshery docs for publishing designs, and replace the video with "how to publish design".

  1. Docs - https://docs.meshery.io/extensions/publishing-a-design.
  2. Video - https://www.youtube.com/watch?v=UCKS4eSB7AY

@Ghat0tkach
Copy link
Member Author

@Chadha93 Thanks again , I will also need to add the design and community member profile

@l5io
Copy link
Contributor

l5io commented Jul 29, 2023

🚀 Preview for commit 996852b at: https://64c558bece1ad713497f7df4--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jul 29, 2023

🚀 Preview for commit be90872 at: https://64c55fbc61f7c9126830c8d8--layer5.netlify.app

@Ghat0tkach
feat:updated links and video
5e4a596 
Signed-off-by: Vikramaditya Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 29, 2023

🚀 Preview for commit 5e4a596 at: https://64c5642a4de7b11617518e9e--layer5.netlify.app

@Ghat0tkach
Copy link
Member Author

Update : There is some issue in responsiveness since my member profile get added automatically .
Will fix this soon

@l5io
Copy link
Contributor

l5io commented Aug 1, 2023

🚀 Preview for commit 5416962 at: https://64c8e46752a8f46f13b2ee95--layer5.netlify.app

@Ghat0tkach Ghat0tkach requested a review from Chadha93 August 1, 2023 20:58
@l5io
Copy link
Contributor

l5io commented Aug 11, 2023

🚀 Preview for commit fa45edb at: https://64d65dc554f3687d19ce58b9--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

🚀 Preview for commit fa45edb at: https://64d65dc554f3687d19ce58b9--layer5.netlify.app

image
last linking sentence @Ghat0tkach ok?

@Ghat0tkach
Update index.mdx
31f614e 
Signed-off-by: Vikramaditya Singh <[email protected]>
@Ghat0tkach
Copy link
Member Author

🚀 Preview for commit fa45edb at: https://64d65dc554f3687d19ce58b9--layer5.netlify.app

image last linking sentence @Ghat0tkach ok?

Thank you @abhijeetgauravm !🙌

@l5io
Copy link
Contributor

l5io commented Aug 12, 2023

🚀 Preview for commit 31f614e at: https://64d806560c870d3e79251df3--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

🚀 Preview for commit 31f614e at: https://64d806560c870d3e79251df3--layer5.netlify.app

image
hey @Ghat0tkach won't it look much appealing when sentences between both images would be at top of the second image or somewhere else?

@Chadha93
Copy link
Member

🚀 Preview for commit 31f614e at: 64d806560c870d3e79251df3--layer5.netlify.app

image hey @Ghat0tkach won't it look much appealing when sentences between both images would be at top of the second image or somewhere else?

@Ghat0tkach, thoughts?

@Ghat0tkach
Copy link
Member Author

Member

🚀 Preview for commit 31f614e at: 64d806560c870d3e79251df3--layer5.netlify.app

image hey @Ghat0tkach won't it look much appealing when sentences between both images would be at top of the second image or somewhere else?

@Ghat0tkach, thoughts?

Yup , seems good !

@l5io
Copy link
Contributor

l5io commented Sep 24, 2023

🚀 Preview for commit 03cd838 at: https://6510900d6686c813419ab732--layer5.netlify.app

@leecalcote leecalcote removed the request for review from Chadha93 September 30, 2023 15:14
@Ghat0tkach
Copy link
Member Author

please have a review , gents

@leecalcote
Copy link
Member

@Ghat0tkach, let's hold off on this until we officially launch MeshMap.

@leecalcote leecalcote added the pr/hold Do not merge this PR label Oct 1, 2023
@stale Stale
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 17, 2024
@vishalvivekm vishalvivekm removed the issue/stale Issue has not had any activity for an extended period of time label Mar 17, 2024
@iArchitSharma
Copy link
Contributor

iArchitSharma commented Mar 18, 2024 •
edited
Loading

@vishalvivekm is it ready to merge?

@Ghat0tkach Ghat0tkach closed this by deleting the head repository Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirentimbadiya hirentimbadiya hirentimbadiya left review comments

@Chadha93 Chadha93 Chadha93 requested changes

@leecalcote leecalcote Awaiting requested review from leecalcote

@theBeginner86 theBeginner86 Awaiting requested review from theBeginner86

Assignees
No one assigned
Labels
area/blog New posts or new blog functionality pr/hold Do not merge this PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Blog]Guide to Publish designs on Meshery Playground for newcomers
9 participants
@Ghat0tkach @l5io @vishalvivekm @abhijeetgauravm @Chadha93 @leecalcote @iArchitSharma @theBeginner86 @hirentimbadiya