-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Add workflow for converting .jpg/.png to .webp #4341
Conversation
Signed-off-by: ayushthe1 <[email protected]>
Signed-off-by: ayushthe1 <[email protected]>
🚀 Preview for commit 3403342 at: https://647dc917b3574c0c04effda7--layer5.netlify.app |
@ayushthe1 Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :) |
@ayushthe1..... |
@@ -0,0 +1,24 @@ | |||
name: ImageToWebpCI | |||
on: | |||
schedule: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than running a cron jobs we can see if specified extension files are pushed than run the workflow. I think it would be better
schedule: | |
push: | |
paths: | |
- '**/*.jpg' # Specify the file extensions you want to trigger the workflow for | |
- '**/*.png' | |
pull_request: | |
paths: | |
- '**/*.jpg' | |
- '**/*.png' |
@suhail34 @Udit-takkar what's the call here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chadha93 i am not sure about this because
If i understood this correctly using https://www.gatsbyjs.com/docs/reference/built-in-components/gatsby-plugin-image/#formats we can pass in options to automatically convert images to webp.
Closing this pr due no activity and active participation. Lets reopen this issue so the new contributors can bring there work here |
Description
This PR fixes #4301
Notes for Reviewers
This shouldn't be merged until it's in a draft state.
Signed commits