[Docs] Hyperlink added for each Role name from Permissions Reference page to Roles page #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age to Roles page Signed-off-by: Ankita Sahu <[email protected]>
1 task
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ankita Sahu <[email protected]>
|
@SAHU-01 As stated by Lee in the issue comments, please make it so that the links open in the same tab, rather than a new one. Moreover, I wonder if you can use string slicing to take the first word from the column header and put in the in the URL, instead of using conditional cases. Can you try that? |
|
@dragon-slayer875 sure let me try this and get back to you real quick! |
|
@dragon-slayer875 I'm afraid that wouldn't be possible if you take a closer look at the conditions, you'll see the sections do not follow a generic URL when mapped, so there is a need to map each of them individually, but please correct me if I'm wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #321
A hyperlink for all available roles in doc has been added and the ones that are not documented in Roles for now (ex: User) are redirected to the default roles page.
Refer to the changes below:
Screen.Recording.2024-07-28.at.10.52.53.PM.mov
Signed commits