Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docsy theme to latest version 0.9.1 #216

Closed
wants to merge 3 commits into from

Conversation

deining
Copy link
Contributor

@deining deining commented Feb 18, 2024

Notes for Reviewers

This PR bumps docsy theme to latest released version 0.9.1.

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 7bcd8c0
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/65f5f0b89fa6ee00082704c2
😎 Deploy Preview https://deploy-preview-216--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@saurabh100ni
Copy link
Contributor

Hi @deining ,
Thanks for your PR! I encourage you to share this in the Website Meeting today at 7:00 AM CT. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.

You're welcome at the meeting

Check to community calendar for more details of meetings at Layers.

@deining
Copy link
Contributor Author

deining commented Feb 19, 2024

Thanks for your invitation! Due to other commitments, I'm unable to attend. Please use this issue tracker if any further input is needed from my side. Looking forward receiving your review of my PRs!

@saurabh100ni
Copy link
Contributor

Thanks for sending the word @deining

@leecalcote
Copy link
Member

Thanks!

@leecalcote leecalcote added the kind/chore Necessary task label Feb 19, 2024
@leecalcote
Copy link
Member

leecalcote commented Feb 19, 2024

@deining what issues did you see upon upgrade (if any at all)?

@deining
Copy link
Contributor Author

deining commented Feb 19, 2024

@deining what issues did you see upon upgrade (if any at all)?

Fortunately, I didn't see any issues when upgrading 😄 .

Copy link
Contributor

@nwanduka nwanduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @deining

I noticed some texts (on the home page) use a font different from the Layer5 brand font. You may want to take a look at that.

image

image

@leecalcote
Copy link
Member

Good eye, @nwanduka. @deining, I wonder if our current customizations fall outside of the safe zone, so to speak. Are you able to identify where we've gone astray?

Signed-off-by: Andreas Deininger <[email protected]>
@deining
Copy link
Contributor Author

deining commented Feb 28, 2024

Thank you for working on this @deining

You are welcome.

I noticed some texts (on the home page) use a font different from the Layer5 brand font.

With an additional commit, I tried to resolve this. Still not 100% the original layout, though.

@deining deining requested a review from nwanduka February 28, 2024 07:28
@nwanduka
Copy link
Contributor

With an additional commit, I tried to resolve this. Still not 100% the original layout, though.

Looks good now. Thank you @deining

@leecalcote
Copy link
Member

@iArchitSharma how are we proceeding here?

@iArchitSharma
Copy link
Contributor

iArchitSharma commented Mar 16, 2024

Fixing this in PR - #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Necessary task
Development

Successfully merging this pull request may close these issues.

5 participants