Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Navigation bar is updated #128

Merged
merged 10 commits into from
Jan 6, 2024

Conversation

Aniumbott
Copy link
Contributor

Notes for Reviewers

This PR fixes #127

2023-12-31.00-49-08.mp4

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Dec 31, 2023

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit c5119ca
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/6595ae18d8f836000876fa8f
😎 Deploy Preview https://deploy-preview-128--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@iArchitSharma
Copy link
Contributor

  • Products should be rename to Solutions
  • Search bar isn't working

@saurabh100ni
Copy link
Contributor

Hi @Aniumbott ,

Thanks for your PR! 🚀 I encourage you to share this in the Website Meeting today at 6:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.

You're welcome in the meeting today

Cheers, and Happy New Year 🥂,

Subscribe to community calendar for more details of meetings at Layer5.

@Aniumbott
Copy link
Contributor Author

  • Products should be rename to Solutions
  • Search bar isn't working

Ya, I just noticed. It was the problem with the CDN scripts which were required for the dropdown, Anyways I've updated it with a custom script.
Also, I have updated the Products -> Solutions.

@iArchitSharma
Copy link
Contributor

@Aniumbott sorry for misunderstanding from my side please change Solutions back to Products

@iArchitSharma
Copy link
Contributor

@Aniumbott are you still working on it?

@Aniumbott
Copy link
Contributor Author

yep

@iArchitSharma
Copy link
Contributor

@Aniumbott oh great please add Cloud and Meshmap link to the top navbar
image

@iArchitSharma
Copy link
Contributor

also when we search the text in search box becomes white, it should remain blackish
image

@Aniumbott
Copy link
Contributor Author

Aniumbott commented Jan 3, 2024

Done 👍
Let me know if anything else is required.

@iArchitSharma
Copy link
Contributor

on home its working fine but when you go to the Cloud or Meshmap and than click on products, icons aren't showing up
image

@Aniumbott
Copy link
Contributor Author

I thought the static folder is the root for images as per in _index.md so I didn't think that the path would be relative, Sorry for this misunderstanding.

@iArchitSharma
Copy link
Contributor

@Aniumbott Thank you for this and I would really appreciate if you can fix one last thing i.e. the active nav color which should change based on the page you are in
image

@iArchitSharma
Copy link
Contributor

@Aniumbott No update here, lets get this active button issue fixed on next PR

Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aniumbott
Copy link
Contributor Author

Ok, I will shift to a separate PR. Sorry, I was busy for a few days.

@iArchitSharma iArchitSharma merged commit e2b3694 into layer5io:master Jan 6, 2024
5 checks passed
@iArchitSharma
Copy link
Contributor

@Aniumbott Please create an issue about it and assign it to yourself

@Aniumbott No update here, lets get this active button issue fixed on next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update the Navigation bar to new design
3 participants