-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Navigation bar is updated #128
Conversation
Signed-off-by: Aniumbott <[email protected]>
Signed-off-by: Aniumbott <[email protected]>
Signed-off-by: Aniumbott <[email protected]>
Signed-off-by: Aniumbott <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @Aniumbott , Thanks for your PR! 🚀 I encourage you to share this in the Website Meeting today at 6:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR. You're welcome in the meeting today Cheers, and Happy New Year 🥂, Subscribe to community calendar for more details of meetings at Layer5. |
Signed-off-by: Aniumbott <[email protected]>
Ya, I just noticed. It was the problem with the CDN scripts which were required for the dropdown, Anyways I've updated it with a custom script. |
@Aniumbott sorry for misunderstanding from my side please change Solutions back to Products |
@Aniumbott are you still working on it? |
yep |
Signed-off-by: Aniumbott <[email protected]>
@Aniumbott oh great please add Cloud and Meshmap link to the top navbar |
… or not Signed-off-by: Aniumbott <[email protected]>
Signed-off-by: Aniumbott <[email protected]>
Done 👍 |
…the landing page Signed-off-by: Aniumbott <[email protected]>
I thought the static folder is the root for images as per in |
@Aniumbott Thank you for this and I would really appreciate if you can fix one last thing i.e. the active nav color which should change based on the page you are in |
@Aniumbott No update here, lets get this active button issue fixed on next PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ok, I will shift to a separate PR. Sorry, I was busy for a few days. |
@Aniumbott Please create an issue about it and assign it to yourself
|
Notes for Reviewers
This PR fixes #127
2023-12-31.00-49-08.mp4
Signed commits