Open
Conversation
Owner
|
Please fix the code duplication first. As to the MoveLineCol not working, maybe "stdcol=GetCol()" would fix the problem |
Owner
|
I think file_check should be extended to fill and return LoadFileOptions object, which would contain extracted file name, line, column, mmap region begin and length. Then the object would be passed to LoadFile as an argument. Thus there would be no need for double parsing of the original file name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is a bigger one, where I think that the code in user.cc demonstrates that it could use a different approach.
The first two changes work as expected. The third, supporting the line column to be passed, does not seem to work due to some reason I could not easily find. I know that the info passed to MoveLineCol is correct, but not much else.