Fix BRE parentheses #123
Open
Fix BRE parentheses #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the parser encountered a left or right parenthesis while parsing an atom, it would check if it was either in ERE mode or if the preceding character was a backslash. This is unreliable as we cannot know at this point if said backslash was itself escaped. Instead, when we encounter a backslash (which we know is not escaped), and are not in ERE mode, check if the next character is a left or right parenthesis, and if so, jump directly to the appropriate point.
|
Note that there is a similar issue with parsing carets in BREs, but unfortunately it can't be fixed as easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the parser encountered a left or right parenthesis while parsing an atom, it would check if it was either in ERE mode or if the preceding character was a backslash. This is unreliable as we cannot know at this point if said backslash was itself escaped. Instead, when we encounter a backslash (which we know is not escaped), and are not in ERE mode, check if the next character is a left or right parenthesis, and if so, jump directly to the appropriate point.