Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: Fix error when a note has no history #11702

Open
wants to merge 1 commit into
base: release-3.2
Choose a base branch
from
Open

Desktop: Fix error when a note has no history #11702

wants to merge 1 commit into from
+1 −1

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jan 22, 2025 •
edited
Loading

Summary

This pull request fixes an error that was logged to the console when viewing a note with no history in the note viewer. This is a regression, caused by a missing null check.

This was originally reported on the forum.

Testing plan

  1. Create a new note.
  2. Open its note history.
  3. Verify that the history panel reads "This note has no history".
  4. Repeat step 2 for a note with history.
  5. Verify that revisions are shown in the dropdown.

@personalizedrefrigerator personalizedrefrigerator added bug It's a bug desktop All desktop platforms v3.2 labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug It's a bug desktop All desktop platforms v3.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@personalizedrefrigerator