Desktop,Mobile,Cli: Include types of synced items in the sync status message

[personalizedrefrigerator]

Summary

This pull request implements a feature request from the forum.

Previously, the sync status message would list a large number of deleted "items" after removing old note versions on the sync target. This pull request should make the status message less confusing.

For example, previously, Deleted remote items: 1024 might be shown after deleting 1024 old note versions. With this pull request, Deleted remote: 1024 (note history) would be shown instead.

Note

Users may be experiencing related issues due to the changes from this pull request, which fixed a bug where old revisions were not removed from the sync target.

Notes

• Currently, tags are listed as other. This is in part to avoid confusion about the different types of tag entities (tag associations and tags).
• Item types are always joined with commas.
  • This may be incorrect for some locales. Suggestions for how to improve this would be welcome!
• Originally, this pull request limited the maximum length of the list of item types. The goal was to prevent the status message from becoming too long (and thus shrinking the available space for the notebook list). A truncated message might look like this:
  • 
    The above message might be confusing. For now, this pull request does not truncate long status messages.

Example status messages

• After adding a new note:
  • 
• After moving a note to the trash:
  • 
• After emptying the trash (permanently deleting 2 notes and a notebook):
  • 
• After creating a revision:
  • 
• After pulling 1 remote item:
  • 
  • Note: At present, item type doesn't always seem to be available for logged "createLocal" events.
• An in-progress sync that 1) enables encryption, 2) permanently deletes a notebook/note, and 3) deletes old note versions:
  • 

[personalizedrefrigerator]

As mentioned in the pull request description, modifiedItemNames.join(', ') isn't ideal for localization purposes.

[mrjo118]

Nice work! I thought about proposing something like this, but glad to see this has been suggested and now even been implemented.

I think particularly in the case of deletions, it would be good to have some kind of breakdown which includes the totals for each category. For example, you might delete 1 note but also 20 revisions are deleted, so seeing 'deleted remote: 21 (notes, note history)' is still going to be scary. You could put the number next to each part in the brackets as well, or if you don't want to make the sync summary even more cluttered, then maybe you could log the total of each part within the breakdown, if that is not done already?