All: Fix a flaky test case in crypto.test.ts #11389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary constant value and if condition Add more test cases
laurent22
reviewed
Nov 14, 2024
Comment on lines
41
to
44
| while (i-- > end) { | ||
| nonce[i] += carry; | ||
| if (nonce[i] !== 0 || carry !== 1) { | ||
| nonce[i] += 1; | ||
| if (nonce[i] !== 0) { | ||
| break; |
There was a problem hiding this comment.
Could this affect data that has already been encrypted with the new encryption method? From the name I'm guessing that not but please confirm. How is this function used?
There was a problem hiding this comment.
This doesn't affect the encrypted data at all. The old implementation and and the new implementation generate exactly the same output with same input (nonce in this case). It's just a optimization.
This function is used when a new chunk of data is encrypted. Each trunk of data is encrypted with the same key and a different nonce, and this function is used to change the nonce.
|
Thanks for checking this issue and fixing it @wh201906! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10696 (comment).
Related CI run:
https://github.com/laurent22/joplin/actions/runs/11815017664/job/32915288005