Add twisted support #18 #19
Conversation
|
The test failures seem to be because twisted dropped 2.6 support... Wouldn't suppose you could too? |
|
I think we could-- none of our Python customers are on 2.6. |
ldclient/__init__.py
Outdated
Conflicts: .gitignore
* add stop for stream producers * add ability to override stream producers and feature store classes * add no-cache header for stream requests * barely tested sse implementation for twisted
There was a problem hiding this comment.
If flush is called on an empty queue, it will block until the next time _consume has actual work to do. This could be longer than 5 seconds if the queue is empty.
I also think flush should force an immediate request with the current queue contents, rather than merely acting as a synchronization point indicating that the next _consume cycle has completed.
This is important for our integration tests-- our test harness connects to the same Pubnub channel as the dev console and checks for the presence of events to verify that the client is sending them properly. For the SDKs that implement flush as I've described it, the harness runs in about 5 minutes. Without flush, the twisted tests have been running for 30 minutes so far since we're waiting up to 5 seconds for each event to appear.
On the plus side the integration tests are passing 👍
* Change to stream_uri/features rather than postfixed event names * Fix flushing to force a real flush immediately * Change user agent for twisted SSE consumer
|
Passes all integration tests with flying colors. |
… parameter (#19) * increase minimum poll interval to 30s * add warning against disabling streaming * add docs for most of the config options
2 participants
No description provided.