chore: update Ruby version from 3.1 to 3.4 in workflows and README#22
Merged
kinyoklion merged 3 commits intomainfrom Apr 2, 2026
Merged
Conversation
The openfeature-sdk ~> 0.6.0 dependency requires Ruby >= 3.4, which broke compatibility with Ruby 3.1-3.3. Widen the dependency to ~> 0.4 so Bundler can resolve to openfeature-sdk 0.5.x on Ruby 3.1-3.3 and 0.6.x on Ruby 3.4+. The provider API surface (ResolutionDetails, Reason, ErrorCode, ProviderMetadata) is unchanged across these versions. Also adds Ruby 3.1 back to the CI matrix. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
@cursor review |
Member
Author
|
We want to keep the version support as it was, but increase the version of ruby we are using. |
The openfeature-sdk ~> 0.6.0 dependency requires Ruby >= 3.4. Update the README to match the gemspec requirement. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
Got it — reverted the dependency and gemspec changes. The PR now just updates the README to say Ruby 3.4+ to match the actual |
Member
Author
|
The CI failure is because CI didn't use 3.4. So there must be workflow updates needed. |
The release-please, manual-publish, and manual-publish-docs workflows still referenced Ruby 3.1, which is incompatible with openfeature-sdk ~> 0.6.0 (requires Ruby >= 3.4). Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
Found it — |
keelerm84
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Bundler found conflicting requirements for the Ruby versionwhen running with Ruby 3.1.7.Describe the solution you've provided
The
openfeature-sdk ~> 0.6.0dependency requires Ruby >= 3.4, and the gemspec'srequired_ruby_versionwas already updated to>= 3.4in #16. However, three workflows and the README still referenced Ruby 3.1:release-please.yml— usedruby-version: 3.1for the CI step during release → updated to3.4manual-publish.yml— usedruby-version: 3.1for the build-and-test step → updated to3.4manual-publish-docs.yml— usedruby-version: 3.1forsetup-ruby→ updated to3.4README.md— stated "Ruby 3.1 and above" → updated to "Ruby 3.4 and above"Describe alternatives you've considered
openfeature-sdkto~> 0.4to restore Ruby 3.1 support: Rejected per reviewer feedback — the intent is to keepopenfeature-sdk ~> 0.6.0and require Ruby 3.4+.Additional context
The
ci.ymlworkflow was already updated to Ruby 3.4 in #16; only the release/publish workflows were missed.Human review checklist
3.1across.github/)Link to Devin session: https://app.devin.ai/sessions/0a8e066ab2c447618bcefa0be007594a
Requested by: @kinyoklion
Note
Low Risk
Low risk: updates only CI/release GitHub Actions configuration and README text, with no runtime code changes. Main risk is CI/publish failures if Ruby 3.4 environment assumptions differ from prior runs.
Overview
Aligns automation and documentation with the project’s Ruby 3.4+ requirement by updating GitHub Actions workflows to run build/test, release, and docs publishing using Ruby
3.4instead of3.1.Updates the README to state support for Ruby
3.4and above.Written by Cursor Bugbot for commit 53daf5e. This will update automatically on new commits. Configure here.