Repository navigation
chore: bump .nvmrc to Node 26.13.0 (Active LTS) and use it in CI - #669
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 3733121. Configure here.
| @@ -1 +1 @@ | |||
| 23.5.0 | |||
| 26.13.0 | |||
There was a problem hiding this comment.
Playwright install hangs on Node 26
Medium Severity
CI and local .nvmrc now use Node 26.13.0 while @playwright/test stays at 1.58.2. That Playwright release hangs in playwright install during browser extraction on Node 26, so e2e setup can stall on a cache miss.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3733121. Configure here.
There was a problem hiding this comment.
Confirmed. With a fresh browsers path, Playwright 1.58.2's playwright install chromium hangs after the download finishes on Node 26.13.0. It completes in about 7s on Node 24. CI on this PR passed only because the browser cache hit. Fixed in #670, which bumps @playwright/test to ^1.64.1; locally, install plus the full e2e suite passes on Node 26.


Description
What does this PR do?
Bumps
.nvmrcfrom23.5.0(Node 23, EOL since 2025-06-01) to26.13.0. That's the newest supported Node release: 26 became Active LTS on 2026-10-28..nvmrc:23.5.0→26.13.0.github/actions/ci/action.yml): hard-codednode-version: '23'→node-version-file: '.nvmrc', so CI actually tests the.nvmrcversion and no longer runs on an EOL Nodecorepack, since Node 25+ doesn't bundle it (e.g.npm i -g pnpm@10.14.0). CI usespnpm/action-setup, so it isn't affectedImplementation details
release-please.ymlstill pins'24'. 24 is supported, so I left it alone.pnpm install --frozen-lockfile,pnpm lint(0 errors),pnpm format:ci,pnpm build,pnpm demo:build,pnpm test(55 files / 840 tests passed). I didn't run Playwright e2e locally; CI covers it.Type of Change
Screenshots/Videos
N/A
Link to Devin session: https://app.devin.ai/sessions/8cf81f9172c34852b06753ff4d5fc0d0
Open in Devin Desktop: https://app.devin.ai/desktop/session/8cf81f9172c34852b06753ff4d5fc0d0?variant=devin
Requested by: @pkaeding