Skip to content

chore: bump .nvmrc to Node 26.13.0 (Active LTS) and use it in CI - #669

Merged
pkaeding merged 1 commit into
mainfrom
devin/1793214408-nvmrc-node-26
Oct 28, 2026
Merged

pkaeding merged 1 commit into
mainfrom
devin/1793214408-nvmrc-node-26

Conversation

@pkaeding

Copy link
Copy Markdown
Contributor

Description

What does this PR do?

Bumps .nvmrc from 23.5.0 (Node 23, EOL since 2025-06-01) to 26.13.0. That's the newest supported Node release: 26 became Active LTS on 2026-10-28.

  • .nvmrc: 23.5.0 → 26.13.0
  • Shared CI action (.github/actions/ci/action.yml): hard-coded node-version: '23' → node-version-file: '.nvmrc', so CI actually tests the .nvmrc version and no longer runs on an EOL Node
  • Local dev on Node 26 needs pnpm installed some way other than corepack, since Node 25+ doesn't bundle it (e.g. npm i -g pnpm@10.14.0). CI uses pnpm/action-setup, so it isn't affected
Implementation details
  • Supported lines according to the Node release schedule: 22 (Maintenance, EOL 2027-04-30), 24 (Maintenance, EOL 2028-04-30), 26 (Active LTS, EOL 2029-04-30). 27 is still alpha; 25 and 23 are EOL.
  • release-please.yml still pins '24'. 24 is supported, so I left it alone.
  • Tested locally on Node 26.13.0 with pnpm 10.14.0: pnpm install --frozen-lockfile, pnpm lint (0 errors), pnpm format:ci, pnpm build, pnpm demo:build, pnpm test (55 files / 840 tests passed). I didn't run Playwright e2e locally; CI covers it.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation (changes to documentation only)
  • 🔧 Refactor (code change that neither fixes a bug nor adds a feature)
  • 🎨 Style (formatting, missing semicolons, etc; no production code change)
  • ⚡ Performance (code change that improves performance)
  • ✅ Test (adding missing tests, refactoring tests; no production code change)
  • 🔨 Chore (updating grunt tasks, build process, etc; no production code change)

Screenshots/Videos

N/A


Link to Devin session: https://app.devin.ai/sessions/8cf81f9172c34852b06753ff4d5fc0d0
Open in Devin Desktop: https://app.devin.ai/desktop/session/8cf81f9172c34852b06753ff4d5fc0d0?variant=devin
Requested by: @pkaeding

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@pkaeding
pkaeding marked this pull request as ready for review October 28, 2026 19:08
@pkaeding
pkaeding requested a review from a team as a code owner October 28, 2026 19:08
@pkaeding
pkaeding merged commit b0423c4 into main Oct 28, 2026
4 of 5 checks passed
@pkaeding
pkaeding deleted the devin/1793214408-nvmrc-node-26 branch October 28, 2026 19:15

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 3733121. Configure here.

Comment thread .nvmrc
@@ -1 +1 @@
23.5.0
26.13.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playwright install hangs on Node 26

Medium Severity

CI and local .nvmrc now use Node 26.13.0 while @playwright/test stays at 1.58.2. That Playwright release hangs in playwright install during browser extraction on Node 26, so e2e setup can stall on a cache miss.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3733121. Configure here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. With a fresh browsers path, Playwright 1.58.2's playwright install chromium hangs after the download finishes on Node 26.13.0. It completes in about 7s on Node 24. CI on this PR passed only because the browser cache hit. Fixed in #670, which bumps @playwright/test to ^1.64.1; locally, install plus the full e2e suite passes on Node 26.

Written by Devin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants