feat: add retry logic to FDv2 polling initializer#1230
Merged
kinyoklion merged 4 commits intomainfrom Mar 30, 2026
Merged
Conversation
The polling initializer now retries up to 3 times on recoverable errors with a 1-second delay between attempts, matching the FDv1 behavior. Removes the oneShot parameter from poll() since the initializer was its only consumer and retry logic now handles error classification at the initializer level.
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
The mock fetch headers.get() returned undefined instead of null, causing a TypeError in getFallback() that triggered retries. Also adds a valid FDv2 response for /sdk/poll/eval URLs.
Contributor
|
@launchdarkly/js-client-sdk size report |
Member
Author
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
joker23
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHUTDOWNsymbol for clean race discrimination between poll results and shutdown signalsoneShotparameter frompoll()/processEvents()since retry logic now lives at the initializer levelNote
Medium Risk
Medium risk because it changes FDv2 initialization behavior by adding retry/delay loops and altering how polling errors are classified, which can affect startup latency and failure modes.
Overview
Adds retry behavior to the FDv2 polling initializer: it now retries up to 3 times with a 1s delay on recoverable
interruptedresults, converts an exhausted retry sequence intoterminal_error, and supports shutdown during both an in-flight poll and the retry sleep via a sentinelSHUTDOWNsymbol.Simplifies
fdv2polling by removing theoneShot/initializer-mode branching fromPollingBase/processEventsand updating all call sites/tests accordingly (includingSourceFactoryProviderping handling and browser test mocks to return FDv2-style poll responses).Written by Cursor Bugbot for commit 1dd4150. This will update automatically on new commits. Configure here.