prepare 9.1.1 release (#309)

## [9.1.1] - 2023-09-19 ### Fixed: - Fixed rare bug in key generation in some contexts generated by the Auto Environment Attributes feature. --------- Co-authored-by: Ben Woskow <[email protected]> Co-authored-by: torchhound <[email protected]> Co-authored-by: Gavin Whelan <[email protected]> Co-authored-by: Louis Chan <[email protected]> Co-authored-by: Matthew Keeler <[email protected]> Co-authored-by: Louis Chan <[email protected]> Co-authored-by: Ember Stevens <[email protected]> Co-authored-by: Ember Stevens <[email protected]> Co-authored-by: Ryan Lamb <[email protected]> Co-authored-by: ld-repository-standards[bot] <113625520+ld-repository-standards[bot]@users.noreply.github.com> Co-authored-by: Kane Parkinson <[email protected]>
launchdarkly · Sep 19, 2023 · ce4a845 · ce4a845
1 parent e7e956c
commit ce4a845
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 27 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to the LaunchDarkly iOS SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [9.1.1] - 2023-09-19
+### Fixed:
+- Fixed rare bug in key generation in some contexts generated by the Auto Environment Attributes feature.
+
 ## [9.1.0] - 2023-09-11
 ### Changed:
 - Deprecated `LDValue.init(integerLiteral: Double)` as this method signature is misleading. A new `LDValue.init(integerLiteral: Int)` signature has been added for clarity.

diff --git a/LaunchDarkly.podspec b/LaunchDarkly.podspec
@@ -2,7 +2,7 @@
 Pod::Spec.new do |ld|
 
   ld.name         = "LaunchDarkly"
-  ld.version      = "9.1.0"
+  ld.version      = "9.1.1"
   ld.summary      = "iOS SDK for LaunchDarkly"
 
   ld.description  = <<-DESC

diff --git a/LaunchDarkly.xcodeproj/project.pbxproj b/LaunchDarkly.xcodeproj/project.pbxproj
@@ -1572,12 +1572,12 @@
 				CODE_SIGN_STYLE = Automatic;
 				DEFINES_MODULE = NO;
 				DYLIB_COMPATIBILITY_VERSION = 9.1.0;
-				DYLIB_CURRENT_VERSION = 9.1.0;
+				DYLIB_CURRENT_VERSION = 9.1.1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
 				GCC_C_LANGUAGE_STANDARD = gnu11;
 				INFOPLIST_FILE = "$(PROJECT_DIR)/LaunchDarkly/LaunchDarkly/Support/Info.plist";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
-				MARKETING_VERSION = 9.1.0;
+				MARKETING_VERSION = 9.1.1;
 				MODULEMAP_FILE = "";
 				PRODUCT_BUNDLE_IDENTIFIER = "com.launchdarkly.Darkly-tvOS";
 				PRODUCT_NAME = LaunchDarkly_tvOS;
@@ -1597,12 +1597,12 @@
 				CODE_SIGN_STYLE = Automatic;
 				DEFINES_MODULE = NO;
 				DYLIB_COMPATIBILITY_VERSION = 9.1.0;
-				DYLIB_CURRENT_VERSION = 9.1.0;
+				DYLIB_CURRENT_VERSION = 9.1.1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
 				GCC_C_LANGUAGE_STANDARD = gnu11;
 				INFOPLIST_FILE = "$(PROJECT_DIR)/LaunchDarkly/LaunchDarkly/Support/Info.plist";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
-				MARKETING_VERSION = 9.1.0;
+				MARKETING_VERSION = 9.1.1;
 				MODULEMAP_FILE = "";
 				PRODUCT_BUNDLE_IDENTIFIER = "com.launchdarkly.Darkly-tvOS";
 				PRODUCT_NAME = LaunchDarkly_tvOS;
@@ -1622,12 +1622,12 @@
 				COMBINE_HIDPI_IMAGES = YES;
 				DEFINES_MODULE = NO;
 				DYLIB_COMPATIBILITY_VERSION = 9.1.0;
-				DYLIB_CURRENT_VERSION = 9.1.0;
+				DYLIB_CURRENT_VERSION = 9.1.1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
 				GCC_C_LANGUAGE_STANDARD = gnu11;
 				INFOPLIST_FILE = "$(PROJECT_DIR)/LaunchDarkly/LaunchDarkly/Support/Info.plist";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
-				MARKETING_VERSION = 9.1.0;
+				MARKETING_VERSION = 9.1.1;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.launchdarkly.Darkly-macOS";
 				PRODUCT_NAME = LaunchDarkly_macOS;
 				SDKROOT = macosx;
@@ -1645,12 +1645,12 @@
 				COMBINE_HIDPI_IMAGES = YES;
 				DEFINES_MODULE = NO;
 				DYLIB_COMPATIBILITY_VERSION = 9.1.0;
-				DYLIB_CURRENT_VERSION = 9.1.0;
+				DYLIB_CURRENT_VERSION = 9.1.1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
 				GCC_C_LANGUAGE_STANDARD = gnu11;
 				INFOPLIST_FILE = "$(PROJECT_DIR)/LaunchDarkly/LaunchDarkly/Support/Info.plist";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
-				MARKETING_VERSION = 9.1.0;
+				MARKETING_VERSION = 9.1.1;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.launchdarkly.Darkly-macOS";
 				PRODUCT_NAME = LaunchDarkly_macOS;
 				SDKROOT = macosx;
@@ -1693,8 +1693,8 @@
 				COPY_PHASE_STRIP = NO;
 				CURRENT_PROJECT_VERSION = 1;
 				DEBUG_INFORMATION_FORMAT = dwarf;
-				DYLIB_COMPATIBILITY_VERSION = 9.0.0;
-				DYLIB_CURRENT_VERSION = 9.0.2;
+				DYLIB_COMPATIBILITY_VERSION = 9.1.0;
+				DYLIB_CURRENT_VERSION = 9.1.1;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				ENABLE_TESTABILITY = YES;
 				FRAMEWORK_VERSION = F;
@@ -1764,8 +1764,8 @@
 				COPY_PHASE_STRIP = NO;
 				CURRENT_PROJECT_VERSION = 1;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
-				DYLIB_COMPATIBILITY_VERSION = 9.0.0;
-				DYLIB_CURRENT_VERSION = 9.0.2;
+				DYLIB_COMPATIBILITY_VERSION = 9.1.0;
+				DYLIB_CURRENT_VERSION = 9.1.1;
 				ENABLE_NS_ASSERTIONS = NO;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				FRAMEWORK_VERSION = F;
@@ -1801,12 +1801,12 @@
 				CODE_SIGN_IDENTITY = "";
 				DEFINES_MODULE = NO;
 				DYLIB_COMPATIBILITY_VERSION = 9.1.0;
-				DYLIB_CURRENT_VERSION = 9.1.0;
+				DYLIB_CURRENT_VERSION = 9.1.1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
 				INFOPLIST_FILE = "$(PROJECT_DIR)/LaunchDarkly/LaunchDarkly/Support/Info.plist";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
 				LD_DYLIB_INSTALL_NAME = "$(DYLIB_INSTALL_NAME_BASE:standardizepath)/$(EXECUTABLE_PATH)";
-				MARKETING_VERSION = 9.1.0;
+				MARKETING_VERSION = 9.1.1;
 				MODULEMAP_FILE = "$(PROJECT_DIR)/Framework/module.modulemap";
 				PRODUCT_BUNDLE_IDENTIFIER = com.launchdarkly.Darkly;
 				PRODUCT_NAME = LaunchDarkly;
@@ -1823,12 +1823,12 @@
 				CODE_SIGN_IDENTITY = "";
 				DEFINES_MODULE = NO;
 				DYLIB_COMPATIBILITY_VERSION = 9.1.0;
-				DYLIB_CURRENT_VERSION = 9.1.0;
+				DYLIB_CURRENT_VERSION = 9.1.1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
 				INFOPLIST_FILE = "$(PROJECT_DIR)/LaunchDarkly/LaunchDarkly/Support/Info.plist";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
 				LD_DYLIB_INSTALL_NAME = "$(DYLIB_INSTALL_NAME_BASE:standardizepath)/$(EXECUTABLE_PATH)";
-				MARKETING_VERSION = 9.1.0;
+				MARKETING_VERSION = 9.1.1;
 				MODULEMAP_FILE = "$(PROJECT_DIR)/Framework/module.modulemap";
 				PRODUCT_BUNDLE_IDENTIFIER = com.launchdarkly.Darkly;
 				PRODUCT_NAME = LaunchDarkly;
@@ -1867,12 +1867,12 @@
 				CODE_SIGN_STYLE = Automatic;
 				DEFINES_MODULE = NO;
 				DYLIB_COMPATIBILITY_VERSION = 9.1.0;
-				DYLIB_CURRENT_VERSION = 9.1.0;
+				DYLIB_CURRENT_VERSION = 9.1.1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
 				GCC_C_LANGUAGE_STANDARD = gnu11;
 				INFOPLIST_FILE = "$(PROJECT_DIR)/LaunchDarkly/LaunchDarkly/Support/Info.plist";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
-				MARKETING_VERSION = 9.1.0;
+				MARKETING_VERSION = 9.1.1;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.launchdarkly.Darkly-watchOS";
 				PRODUCT_NAME = LaunchDarkly_watchOS;
 				SDKROOT = watchos;
@@ -1891,12 +1891,12 @@
 				CODE_SIGN_STYLE = Automatic;
 				DEFINES_MODULE = NO;
 				DYLIB_COMPATIBILITY_VERSION = 9.1.0;
-				DYLIB_CURRENT_VERSION = 9.1.0;
+				DYLIB_CURRENT_VERSION = 9.1.1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
 				GCC_C_LANGUAGE_STANDARD = gnu11;
 				INFOPLIST_FILE = "$(PROJECT_DIR)/LaunchDarkly/LaunchDarkly/Support/Info.plist";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
-				MARKETING_VERSION = 9.1.0;
+				MARKETING_VERSION = 9.1.1;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.launchdarkly.Darkly-watchOS";
 				PRODUCT_NAME = LaunchDarkly_watchOS;
 				SDKROOT = watchos;

diff --git a/LaunchDarkly/LaunchDarkly/Models/Context/Modifier.swift b/LaunchDarkly/LaunchDarkly/Models/Context/Modifier.swift
@@ -47,8 +47,7 @@ class AutoEnvContextModifier {
     private func applicationRecipe() -> ContextRecipe {
         let keyCallable: () -> (String) = {
             Util.sha256(
-                (self.environmentReporter.applicationInfo.applicationId ?? "") + ":" +
-                (self.environmentReporter.applicationInfo.applicationVersion ?? "")
+                (self.environmentReporter.applicationInfo.applicationId ?? "")
             ).base64UrlEncodedString
         }
 

diff --git a/LaunchDarkly/LaunchDarkly/ServiceObjects/EnvironmentReporting/ReportingConsts.swift b/LaunchDarkly/LaunchDarkly/ServiceObjects/EnvironmentReporting/ReportingConsts.swift
@@ -1,6 +1,6 @@
 import Foundation
 
 struct ReportingConsts {
-    static let sdkVersion = "9.1.0"
+    static let sdkVersion = "9.1.1"
     static let sdkName = "ios-client-sdk"
 }
diff --git a/LaunchDarkly/LaunchDarklyTests/Models/Context/ModifierSpec.swift b/LaunchDarkly/LaunchDarklyTests/Models/Context/ModifierSpec.swift
@@ -148,7 +148,7 @@ final class ModifierSpec: XCTestCase {
         let outputContext = underTest.modifyContext(input)
         let outputKey = outputContext.contexts.first(where: { $0.kind == Kind("ld_application") })!.getValue(Reference("key"))
         // expected key is the hash of the concatanation of id and version
-        let expectedKey = Util.sha256("idStub:versionStub").base64UrlEncodedString.toLDValue()
+        let expectedKey = Util.sha256("idStub").base64UrlEncodedString.toLDValue()
         XCTAssertEqual(expectedKey, outputKey)
     }
 
@@ -164,7 +164,7 @@ final class ModifierSpec: XCTestCase {
         let outputContext = underTest.modifyContext(input)
         let outputKey = outputContext.contexts.first(where: { $0.kind == Kind("ld_application") })!.getValue(Reference("key"))
         // expect version to be dropped for hashing
-        let expectedKey = Util.sha256("myID:").base64UrlEncodedString.toLDValue()
+        let expectedKey = Util.sha256("myID").base64UrlEncodedString.toLDValue()
         XCTAssertEqual(expectedKey, outputKey)
     }
 }
diff --git a/README.md b/README.md
@@ -49,7 +49,7 @@ To include LaunchDarkly in a Swift package, simply add it to the dependencies se
 
 ```swift
 dependencies: [
-    .package(url: "https://github.com/launchdarkly/ios-client-sdk.git", .upToNextMinor(from: "9.0.2"))
+    .package(url: "https://github.com/launchdarkly/ios-client-sdk.git", .upToNextMinor(from: "9.1.1"))
 ]
 ```