Do not purge httpcache when transport or backend fails. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchheda-ld
requested review from
RookieRick,
zurab-darkly and
singhshalinis01
httpcache_test.go
Outdated
| resetTest() | ||
| ctx, cancel := context.WithTimeout(context.Background(), 10*time.Millisecond) | ||
| defer cancel() | ||
| req, err := http.NewRequestWithContext(ctx, "GET", s.server.URL+"/evictonerror", nil) |
There was a problem hiding this comment.
It doesn't look like these tests ran in CI 🤔
one change - We added a handler for /keeponerror but we are using s.server.URL+"/evictonerror" here. Need to keep both same.
Other than these the PR is looking good
There was a problem hiding this comment.
Yea we don't run it perhaps there was never a need coz it was simply cloned and never a commit was added. I ran tests locally and here is the result from latest commit.
Running tool: /Users/mahekchheda/.goenv/versions/1.22.7/bin/go test -timeout 10m -tags launchdarkly_easyjson -run ^(TestCacheableMethod|TestDontStorePartialRangeInCache|TestGetOnlyIfCachedHit|TestGetOnlyIfCachedMiss|TestGetNoStoreRequest|TestGetNoStoreResponse|TestGetWithEtag|TestGetWithLastModified|TestGetWithVary|TestGetWithDoubleVary|TestKeepOnError|TestGetWith2VaryHeaders|TestGetVaryUnused|TestUpdateFields|TestParseCacheControl|TestNoCacheRequestExpiration|TestNoCacheResponseExpiration|TestReqMustRevalidate|TestRespMustRevalidate|TestFreshExpiration|TestMaxAge|TestMaxAgeZero|TestBothMaxAge|TestMinFreshWithExpires|TestEmptyMaxStale|TestMaxStaleValue|TestGetEndToEndHeaders|TestStaleIfErrorRequest|TestStaleIfErrorRequestLifetime|TestStaleIfErrorResponse|TestStaleIfErrorResponseLifetime)$ github.com/launchdarkly/httpcache
ok github.com/launchdarkly/httpcache 0.390s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In streamer we are often seeing issues where if 1 varnish node is unavailable, we end up evicting good data from the local cache and thus leads to full data transfer on retry.
Instead we want to introduce a new cache directory
keep-on-errorwhich instructs http cache then when backend or transport fails, do not purge current entry. It still returns underlying error to main flow.stale-if-errorcan still overridekeep-on-errordirective it returns cached entry.