Compile-time support for external drivers #3889
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Not on this repo, but it would solve an issue for the
sqlx-exasol
driver: bobozaur/sqlx-exasol#9.With the changes here, the compile-time macros can be redefined by external drivers through usage of
sqlx_macros_core::query::expand_input()
with a customQueryDriver
. Furthermore, asqlx-cli
like binary can be exposed as well, since theinstall_default_drivers()
call was moved to thesqlx-cli
binaries. With these changes, the custom driver binary (that depends onsqlx-cli
as a library) can install its own driver (this would panic with the current state of things).Is this a breaking change?
Nope, it's internal only. Should not affect anything else at all.