Skip to content

Dont use EXPLAIN in nullability check for QuestDB #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abonander merged 2 commits into from
Dec 24, 2024
+11 −12
Merged

Dont use EXPLAIN in nullability check for QuestDB #3640

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a44f35
Dont use `EXPLAIN` in nullability check for QuestDB
SuficioAC Dec 16, 2024
610da30
Add `PgConnection::is_explain_available`
Suficio Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions sqlx-postgres/src/connection/describe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,15 @@ WHERE rngtypid = $1
Ok(array_oid)
}

/// Check whether EXPLAIN statements are supported by the current connection
fn is_explain_available(&self) -> bool {
let parameter_statuses = &self.inner.stream.parameter_statuses;
let is_cockroachdb = parameter_statuses.contains_key("crdb_version");
let is_materialize = parameter_statuses.contains_key("mz_version");
let is_questdb = parameter_statuses.contains_key("questdb_version");
!is_cockroachdb && !is_materialize && !is_questdb
}

pub(crate) async fn get_nullable_for_columns(
&mut self,
stmt_id: StatementId,
Expand Down Expand Up @@ -486,18 +495,8 @@ WHERE rngtypid = $1
)
})?;

// If the server is CockroachDB or Materialize, skip this step (#1248).
if !self
.inner
.stream
.parameter_statuses
.contains_key("crdb_version")
&& !self
.inner
.stream
.parameter_statuses
.contains_key("mz_version")
{
// If the server doesn't support EXPLAIN statements, skip this step (#1248).
if self.is_explain_available() {
// patch up our null inference with data from EXPLAIN
let nullable_patch = self
.nullables_from_explain(stmt_id, meta.parameters.len())
Expand Down
Loading