Skip to content

Change the modules to adhere to the UMD API #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sorig
Copy link

@sorig sorig commented Apr 22, 2018

This is a simple change to the header and footer of the module compilations. The universal module defintion makes MLWeb easily usable from as many environments as possible. Currently the modules assign a global variable which is fine in many cases but may not be compatible with various require implementations (including d3's require implementation used by Observable notebooks)

@sorig sorig mentioned this pull request Apr 22, 2018
@Fil
Copy link

Fil commented Aug 28, 2018

Hi @sorig, thanks for the work on this issue. Did you manage to actually use the library in Observable? I'd like to try its eigenvalues functions but I'm stuck at https://beta.observablehq.com/d/587aebd683e63fb8

@sorig
Copy link
Author

sorig commented Aug 28, 2018

@Fil Looks like you figured it out :)

@lauerfab although Fil can use MLweb through the version I host on my university's server, it would be a more sustainable solution to get this PR merged and host the scripts on a reliable CDN with HTTPS access (#7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants