Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types sourcemanager and llmanager #550

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

andresgutgon
Copy link
Contributor

What?

We were generating types wrongly and when using these packages types were not recognized by the LSP (Language Server Protocol)

The problem is we use alias @/model instead of ../../model' and those alias has to be resolved in the same way by tsconfig` and by rollup.

Also we were generating a lot crap in the dist folder. Now is only index.js and index.d.ts

Before LSP

No auto completion
image

After LSP [insert feels good meme here]

image

Before dist folder

image

After dist folder

image

Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: d9adc7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@latitude-data/source-manager Minor
@latitude-data/llm-manager Minor
@latitude-data/server Patch
@latitude-data/cli Patch
@latitude-data/display_table Patch
@latitude-data/athena-connector Patch
@latitude-data/bigquery-connector Patch
@latitude-data/clickhouse-connector Patch
@latitude-data/databricks-connector Patch
@latitude-data/duckdb-connector Patch
@latitude-data/mssql-connector Patch
@latitude-data/mysql-connector Patch
@latitude-data/postgresql-connector Patch
@latitude-data/snowflake-connector Patch
@latitude-data/sqlite-connector Patch
@latitude-data/test-connector Patch
@latitude-data/trino-connector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

We were generating types wrongly and when using these packages types
were not recognized by the LSP (Language Server Protocol)
@andresgutgon andresgutgon force-pushed the fix/types-sourcemanager-and-llmanager branch from dca0275 to d9adc7b Compare June 28, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant