Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support materialize tables with JSONB fields #544

Merged

Conversation

andresgutgon
Copy link
Contributor

Describe your changes

While doing some tests with materialize I saw we don't treat JSONB columns as jsonb so I added a new data type for it

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: 5c19134

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@latitude-data/postgresql-connector Minor
@latitude-data/source-manager Minor
@latitude-data/query_result Minor
@latitude-data/server Patch
@latitude-data/cli Patch
@latitude-data/display_table Patch
@latitude-data/athena-connector Patch
@latitude-data/bigquery-connector Patch
@latitude-data/clickhouse-connector Patch
@latitude-data/databricks-connector Patch
@latitude-data/duckdb-connector Patch
@latitude-data/mssql-connector Patch
@latitude-data/mysql-connector Patch
@latitude-data/snowflake-connector Patch
@latitude-data/sqlite-connector Patch
@latitude-data/test-connector Patch
@latitude-data/trino-connector Patch
@latitude-data/llm-manager Patch
@latitude-data/client Patch
@latitude-data/react Patch
@latitude-data/svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -191,6 +191,8 @@ export default class PostgresConnector extends BaseConnector<ConnectionParams> {
case pgtypes.builtins.TIMESTAMP:
case pgtypes.builtins.TIMESTAMPTZ:
return DataType.Datetime
case pgtypes.builtins.JSONB:
return DataType.JSONB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should check the rest of connectors

@andresgutgon andresgutgon merged commit 5c4e829 into canary Jun 27, 2024
4 checks passed
@andresgutgon andresgutgon deleted the feature/support-materialize-table-with-jsonb-columns branch June 27, 2024 08:13
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants