Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OR consolidation #1659

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

OR consolidation #1659

wants to merge 17 commits into from

Conversation

FrankMittelbach
Copy link
Member

Internal housekeeping

Status of pull request

  • Feedback wanted
  • Under development

Checklist of required changes before merge will be approved

  • [n/a] Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

@FrankMittelbach
Copy link
Member Author

At this point in time I'm just looking for feedback on code and names for the sockets and hooks. If those are ok, then the next step is integration and consolidation of the documentation (and the a final review).

@davidcarlisle
Copy link
Member

I'm not overly fond of OR I think because it's hard not to read it as the boolean connective or, even when you've been using it in this way for decades.

Other possibilities are longer though. output is one possibility output/column/outputbox doesn't read too badly.
shipout also comes to mind but may get confusing with existing shipout hooks.

@FrankMittelbach
Copy link
Member Author

Other possibilities are longer though. output is one possibility output/column/outputbox doesn't read too badly.
shipout also comes to mind but may get confusing with existing shipout hooks.

I would argue that "shipout" is wrong, as these and hooks sockets apply even if during shipout everything is aborted, so these are really different things: this here is building the page regardless of what later happens with it and shipout is shipping something out that has been preconstructed earlier by this OR. Another possible name could therefore be something like buildpage/page/outputbox or just build/... since the next level is always "page" or "column"

@davidcarlisle
Copy link
Member

since the next level is always "page" or "column"

Ah. build works quite well then

@u-fischer
Copy link
Member

Do packages like manyfoot or reledmac need more sockets or hooks for additional footnote systems?

@FrankMittelbach
Copy link
Member Author

Do packages like manyfoot or reledmac need more sockets or hooks for additional footnote systems?

  • with its current implementation manyfoot does not (it simply uses the column/before hook)
  • reledmac overwrites \@makecol so will work in that respect, but if it could be implemented using the existing hooks or needs further ones remains to be seen.

See [email protected] for package analysis

check for void \@outputpage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants