Skip to content

Avoid signed-to-unsigned promotion in negative literal comparison #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2025
Merged

Avoid signed-to-unsigned promotion in negative literal comparison #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions C_ESR_METER.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,8 +1185,8 @@ void loop() {
// Clear "button release" message
lcd.clear();

// Force max unsigned long to enable manual power-off
AutoOffTimer = -1;
// Set max value to enable manual power-off
AutoOffTimer = UINT32_MAX;

} else { // Sort press to clear warning

Expand All @@ -1201,10 +1201,7 @@ void loop() {
}

// Check for "lock" status
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wsign-compare"
if (AutoOffTimer == -1){
#pragma GCC diagnostic pop
if (AutoOffTimer == UINT32_MAX){
// Re-display "lock char" to upper right corner
lcd.setCursor(15, 0);
lcd.write(LOCK);
Expand Down Expand Up @@ -1250,8 +1247,8 @@ void loop() {
// Set "Power On", keeping to HIGH the POWER_OFF output (USB DEBUG) forces battery power if present
Set_Power_On;

// Force max unsigned long to enable manual power-off
AutoOffTimer = -1;
// Set max value to enable manual power-off
AutoOffTimer = UINT32_MAX;

// Display "lock char" to upper right corner
lcd.setCursor(15, 0);
Expand Down