Parpadeo del background al navegar en darkmode resuelto #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… getSystemPreference and getThemFromLocalStorage functions into a getThemePreference and domcontentloaded eventlistener removed to ensure JS runs before the document loads
✅ Deploy Preview for snazzy-swan-aa87f4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripción
1: las funciones getSystemPreference and getThemFromLocalStorage se mergearon en una sola llamada getThemePreference
2: se agrega la directiva is:inline por temas de client-side rendering and interactivity, de esta manera astro no procesa el JS y se carga justo antes de que el body o el document sea renderizado
3: se cambia de posicion, antes el script estaba despues del layout, y ahora esta antes, es decir al inicio del body
4: se elimina del script el evento domcontentloaded para asegurar que el JS corra antes de que el documento cargue
en si, toda la pr es un refactor, donde no se eliminan ni se agregan dependencias.
Problema solucionado
elimina el parpadeo del background al navegar en modo oscuro. antes por la posicion del script y el evento domconntenloaded, el JS para actualizar las clases del body con "oscuro" ocurrian despues de que el documento cargara y fuera renderizado por esto ocurria el parpadeo
Capturas de pantallas del codigo para visualizar mas facil los cambios que hice.
Comprobación de cambios
me tome la molestia de hacer un despliegue de mi propia rama en vercel para verificar los cambios y comprobar que el sitio no esta roto como te comente por alla en discord xd, y aunque el video lo grabe en mi localhost, la funcionalidad es la misma
2024-03-07.13-22-30.mp4
sin mas que agregar creo que solo te queda por aceptar la pull request bro :V