Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give simpleHeaders to simpleCorsResourcePolicy #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

give simpleHeaders to simpleCorsResourcePolicy #26

wants to merge 1 commit into from

Commits on Aug 30, 2019

  1. give simpleHeaders to simpleCorsResourcePolicy 

    It makes more sense to give `simpleHeaders` explicitely to the `simpleCorsResourcePolicy`, and by extension to `simpleCors`.

The reason for this is that the preflight request chrome and firefox make vie OPTIONS includes `content-type`, resulting in a 400. As the documentation states, all `simpleHeaders` _except_ `content-type` are implicit when passing the empty list to `corsRequestHeaders`.

I hope this is ok, let me know if I misunderstood the intention regarding `simpleCors`.
    @2mol
    2mol authored Aug 30, 2019
    Configuration menu
    Copy the full SHA
    e077a05 View commit details
    Browse the repository at this point in the history