Support for missing mapping for INT2 and INT8 data types #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added INT2 and INT8 mapping to MAP_ELEMENT method of ZCL_SWAG_MAP_TYPE class to prevent short dumps. INT8 does not exists before ABAP version 7.50 so added it as a public constant to current class as hard coded value.
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
|
@sercankd thanks for the PR, can you help to pretty print the full class source code? Keywords upper case |
![abaplint[bot]](https://avatars.githubusercontent.com/in/960?s=60&v=4){kind=small}
|
|
||
| constants TYPEKIND_INT8 type ABAP_TYPEKIND value '8' ##NO_TEXT. | ||
|
|
||
| class-methods GET_TYPEDESCR |
There was a problem hiding this comment.
Indentation problem, expected 4 spaces
Suggest following fix,
Suggested change
| class-methods GET_TYPEDESCR | |
| class-methods GET_TYPEDESCR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added INT2 and INT8 mapping to MAP_ELEMENT method of ZCL_SWAG_MAP_TYPE class to prevent short dumps. INT8 does not exists before ABAP version 7.50 so added it as a public constant to current class as hard coded value.
Reference to issue #69
Best regards,