refactor(typesense): remove unused exists checks #847
Conversation
|
@tharropoulos could you review this, just to be sure? |
saibotk
force-pushed
the
10.x
branch
2 times, most recently
from
20e4507 to
ed0c5e3
Compare
|
We could even remove the What are the plans regarding the exists field in the typesense sdk? EDIT: Updated my code to also set the exists field when the server has the collection to be 100% correct. |
In laravel#820 we introduced an exists check method, which then lead to static state issues as described in laravel#845 Those where addressed in laravel#846 But now that the function always double-checks the existence, we can remove the exists check entirely and only rely on the Typesense server response for this state. This "fixes" issues where the server already has a collection and the client would try to recreate it. E.g. when it has flushed the index and another process or worker then creates the collection.
|
Thanks for iterating upon the PR! I'll have to check it first thing on Monday, as I'm away from my laptop for this weekend. I'll get back to you as soon as I can |
|
Looking back on it, the verbosity used on the previous PR might be overkill, and after spending some time messing with it, it seems to work just fine. CC: @jasonbosco could you also take a look at the code yourself? Looks just fine to me |
|
I feel like this is pretty much ready otherwise, so i will mark this as ready :) |
In #820 we introduced an exists check method, which then lead to static state issues as described in #845
Those where addressed in #846
But now that the function always double-checks the existence, we can remove the exists check entirely and only rely on the Typesense server response for this state.
This "fixes" issues where the server already has a collection and the client would try to recreate it. E.g. when it has flushed the index and another process or worker then creates the collection.