Skip to content

Conversation

@jeffersonrucu
Copy link
Contributor

@jeffersonrucu jeffersonrucu commented Nov 8, 2025

This PR corrects two minor syntax issues in the rustfs.stub file for Laravel Sail.

1. Correct Healthcheck YAML Syntax

The healthcheck.test command was defined using an invalid multi-line flow-style list ([]), which causes a YAML parsing error (e.g., "Unable to parse at line...") when Docker Compose tries to read the file after publishing the stub.

This commit 6d63366 updates the definition to use the standard YAML block-style list (using hyphens -), which is the correct syntax for this command.

Before:

    healthcheck:
      test:
      [
        "CMD",
        "sh", "-c",
        "curl -f [http://127.0.0.1:9000/health](http://127.0.0.1:9000/health) && curl -f [http://127.0.0.1:9001/health](http://127.0.0.1:9001/health)"
      ]

After:

    healthcheck:
      test:
        - "CMD"
        - "sh"
        - "-c"
        - "curl -f [http://127.0.0.1:9000/health](http://127.0.0.1:9000/health) && curl -f [http://127.0.0.1:9001/health](http://127.0.0.1:9001/health)"

2. Remove Trailing Comma

A trailing comma was removed from the RUSTFS_LOG_LEVEL environment
variable. While some YAML parsers may tolerate this, it's cleaner and
more consistent to remove it.

Before:

        RUSTFS_LOG_LEVEL: 'info',

After:

        RUSTFS_LOG_LEVEL: 'info'

Evidence

image
Recording.2025-11-08.124353.online-video-cutter.com.mp4
➜  docker -v
Docker version 28.3.2, build 578ccf6

The healthcheck.test command was defined using an invalid multi-line flow-style list ([]), which causes YAML parsing failures.

This commit updates the definition to use the correct block-style list syntax (using -).

Additionally, removes a trailing comma from the RUSTFS_LOG_LEVEL environment variable.
@francoism90
Copy link
Contributor

@jeffersonrucu Thanks for the fixes!

@taylorotwell
Copy link
Member

taylorotwell commented Nov 9, 2025

Why is this not just a one line string?

@taylorotwell taylorotwell merged commit 1bf3b88 into laravel:1.x Nov 9, 2025
6 checks passed
@jeffersonrucu
Copy link
Contributor Author

Hi, @taylorotwell
I believed the line break would make it easier to read, but I also don’t see a problem keeping it on a single line since it’s not a long test group. Thanks a lot for the review and the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants